Conditional check reordering (#13415)

Summary:
This change is addressing a valid concern raised in #13408 (comment).

Pull Request resolved: #13415

Test Plan: Existing test collateral.

Reviewed By: cbi42

Differential Revision: D69999071

Pulled By: mszeszko-meta

fbshipit-source-id: 5ebb195b2b83701e06c33bfcb19c57d9ac1c1dc6

Author: mszeszko-meta

db/arena_wrapped_db_iter.cc

@@ -67,13 +67,13 @@ void ArenaWrappedDBIter::Init(
 void ArenaWrappedDBIter::MaybeAutoRefresh(bool is_seek,
                                           DBIter::Direction direction) {
   if (cfh_ != nullptr && read_options_.snapshot != nullptr && allow_refresh_ &&
-      read_options_.auto_refresh_iterator_with_snapshot && status().ok()) {
+      read_options_.auto_refresh_iterator_with_snapshot) {
     // The intent here is to capture the superversion number change
     // reasonably soon from the time it actually happened. As such,
     // we're fine with weaker synchronization / ordering guarantees
     // provided by relaxed atomic (in favor of less CPU / mem overhead).
     uint64_t cur_sv_number = cfh_->cfd()->GetSuperVersionNumberRelaxed();
-    if (sv_number_ != cur_sv_number) {
+    if ((sv_number_ != cur_sv_number) && status().ok()) {
       // Changing iterators' direction is pretty heavy-weight operation and
       // could have unintended consequences when it comes to prefix seek.
       // Therefore, we need an efficient implementation that does not duplicate