Skip to content

Commit cdd9ce6

Browse files
committed
rocksdb/db.h: GetDbIdentity comment: ID comes from MANIFEST
Commit 98c33cb changed the default for the write_dbid_to_manifest option, so this ID now comes from MANIFEST and not IDENTITY. Update the comment to reflect that. Remove 2 unneeded words from the comment on GetDbSessionId since it refers to this function.
1 parent 4ac7fcb commit cdd9ce6

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

include/rocksdb/db.h

+5-4
Original file line numberDiff line numberDiff line change
@@ -1989,15 +1989,16 @@ class DB {
19891989

19901990
virtual Status VerifyChecksum() { return VerifyChecksum(ReadOptions()); }
19911991

1992-
// Returns the unique ID which is read from IDENTITY file during the opening
1993-
// of database by setting in the identity variable
1994-
// Returns Status::OK if identity could be set properly
1992+
// Copies the database's unique ID into identity. The ID is read from the
1993+
// MANIFEST file when opening the database. See the write_dbid_to_manifest
1994+
// options for details.
1995+
// Returns Status::OK if identity was set.
19951996
virtual Status GetDbIdentity(std::string& identity) const = 0;
19961997

19971998
// Return a unique identifier for each DB object that is opened
19981999
// This DB session ID should be unique among all open DB instances on all
19992000
// hosts, and should be unique among re-openings of the same or other DBs.
2000-
// (Two open DBs have the same identity from other function GetDbIdentity when
2001+
// (Two open DBs have the same identity from GetDbIdentity when
20012002
// one is physically copied from the other.)
20022003
virtual Status GetDbSessionId(std::string& session_id) const = 0;
20032004

0 commit comments

Comments
 (0)