sysinfo: 0.20.4 -> 0.26.8

Summary:
Update sysinfo from 0.20.4 to 0.26.8.

The main motivation is to pick up the upstream change in `System::new`, which it no longer loads CPU info by default. This results as a 20x speed up in some of our hosts with powerful CPUs.

Reviewed By: chadaustin, MichaelCuevas

Differential Revision: D41813852

fbshipit-source-id: 678bd0ec36d4771caa8396810355212eec593bb9

Author: fanzeyi

eden/fs/cli_rs/edenfs-client/Cargo.toml

@@ -24,7 +24,7 @@ regex = "1.6.0"
 serde = { version = "1.0.136", features = ["derive", "rc"] }
 serde_json = { version = "1.0.79", features = ["float_roundtrip", "unbounded_depth"] }
 subprocess = "0.2.7"
-sysinfo = "0.20.4"
+sysinfo = "0.26.8"
 thrift-types = { version = "0.1.0", path = "../../../scm/lib/thrift-types" }
 thrift_streaming = { version = "0.1.0", path = "../../service/thrift_streaming" }
 tokio = { version = "1.21.2", features = ["full", "test-util", "tracing"] }

eden/fs/cli_rs/edenfs-commands/Cargo.toml

@@ -26,7 +26,7 @@ serde = { version = "1.0.136", features = ["derive", "rc"] }
 serde_json = { version = "1.0.79", features = ["float_roundtrip", "unbounded_depth"] }
 shlex = "1.0"
 subprocess = "0.2.7"
-sysinfo = "0.20.4"
+sysinfo = "0.26.8"
 tabular = "0.2.0"
 termwiz = { version = "0.18", features = ["widgets"] }
 thrift-types = { version = "0.1.0", path = "../../../scm/lib/thrift-types" }

eden/fs/cli_rs/edenfs-commands/src/minitop.rs

@@ -204,7 +204,11 @@ impl Process {
 
     /// Test if this `Process` is still running.
     fn is_running(&self, system: &System) -> bool {
-        system.process(self.pid as Pid).is_some()
+        #[cfg(not(windows))]
+        let pid = Pid::from(self.pid);
+        #[cfg(windows)]
+        let pid = Pid::from(self.pid as usize);
+        system.process(pid).is_some()
     }
 }
 

eden/fs/cli_rs/edenfs-utils/Cargo.toml

@@ -12,7 +12,7 @@ anyhow = "1.0.65"
 edenfs-error = { version = "0.1.0", path = "../edenfs-error" }
 glob = "0.3"
 subprocess = "0.2.7"
-sysinfo = "0.20.4"
+sysinfo = "0.26.8"
 tracing = "0.1.35"
 
 [target.'cfg(target_os = "linux")'.dependencies]

eden/fs/cli_rs/edenfs-utils/src/lib.rs

@@ -22,6 +22,7 @@ use edenfs_error::ResultExt;
 use glob::glob;
 use subprocess::Exec;
 use subprocess::Redirection;
+use sysinfo::Pid;
 use sysinfo::ProcessExt;
 use sysinfo::SystemExt;
 use tracing::trace;
@@ -134,7 +135,7 @@ pub fn get_executable(pid: sysinfo::Pid) -> Option<PathBuf> {
     if system.refresh_process(pid) {
         if let Some(process) = system.process(pid) {
             let executable = process.exe();
-            trace!(pid, ?executable, "found process executable");
+            trace!(%pid, ?executable, "found process executable");
 
             #[cfg(unix)]
             {
@@ -150,7 +151,7 @@ pub fn get_executable(pid: sysinfo::Pid) -> Option<PathBuf> {
                 return Some(executable.into());
             }
         } else {
-            trace!(pid, "unable to find process");
+            trace!(%pid, "unable to find process");
         }
     } else {
         trace!("unable to load process information");
@@ -159,7 +160,7 @@ pub fn get_executable(pid: sysinfo::Pid) -> Option<PathBuf> {
     None
 }
 
-pub fn is_process_running(pid: sysinfo::Pid) -> bool {
+pub fn is_process_running(pid: Pid) -> bool {
     let mut system = sysinfo::System::new();
 
     if system.refresh_process(pid) {
@@ -213,12 +214,8 @@ pub fn stop_buckd_for_repo(path: &Path) {
 pub fn is_buckd_running_for_path(path: &Path) -> bool {
     let pid_file = path.join(".buckd").join("pid");
     let file_contents = read_to_string(&pid_file).unwrap_or_default();
-    #[cfg(windows)]
-    let buck_pid_parse = file_contents.trim().parse::<usize>();
-    #[cfg(not(windows))]
-    let buck_pid_parse = file_contents.trim().parse::<i32>();
 
-    if let Ok(buck_pid) = buck_pid_parse {
+    if let Ok(buck_pid) = file_contents.trim().parse::<Pid>() {
         is_process_running(buck_pid)
     } else {
         false