Add SqlBookmarks facet to all Repo traits and containers

Summary:
Add `SqlBookmarksRef` to Repo trait aliases and `SqlBookmarks` facet to all concrete Repo containers throughout the Mononoke codebase. This makes `repo.sql_bookmarks()` available everywhere, which is needed for pessimistic pushrebase to call `SqlBookmarks::start_locked_transaction()`.

Updated traits:
- `bookmarks_movement::Repo`
- `cross_repo_sync::Repo`

Updated containers:
- `bookmarks_movement::TestRepo` (git_mapping.rs)
- `cross_repo_sync::ConcreteRepo` + `TestRepo`
- `backsyncer::Repo`
- `land_service::Repo`
- `repo_client::RepoClientRepo`
- `mononoke_api::Repo`
- `tools/admin::cross_repo::Repo`
- `tools/repo_import::Repo`

Part of the pessimistic pushrebase locking project — see design doc at `docs/plans/2026-04-13-pessimistic-pushrebase-locking-design.md`.

Reviewed By: YousefSalama

Differential Revision: D100809456

fbshipit-source-id: b151ad4639412b94e08ac1712ad4a7d03db0961a

Author: RajivTS

eden/mononoke/features/commit_rewriting/backsyncer/BUCK

@@ -59,6 +59,7 @@ rust_library(
         "//eden/mononoke/repo_attributes/bonsai_globalrev_mapping:bonsai_globalrev_mapping",
         "//eden/mononoke/repo_attributes/bonsai_hg_mapping:bonsai_hg_mapping",
         "//eden/mononoke/repo_attributes/bookmarks:bookmarks",
+        "//eden/mononoke/repo_attributes/bookmarks/dbbookmarks:dbbookmarks",
         "//eden/mononoke/repo_attributes/commit_graph/commit_graph:commit_graph",
         "//eden/mononoke/repo_attributes/filenodes:filenodes",
         "//eden/mononoke/repo_attributes/filestore:filestore",

eden/mononoke/features/commit_rewriting/backsyncer/Cargo.toml

@@ -18,6 +18,7 @@ cloned = { version = "0.1.0", git = "https://github.com/facebookexperimental/rus
 commit_graph = { version = "0.1.0", path = "../../../repo_attributes/commit_graph/commit_graph" }
 context = { version = "0.1.0", path = "../../../servers/slapi/slapi_server/context" }
 cross_repo_sync = { version = "0.1.0", path = "../../cross_repo_sync" }
+dbbookmarks = { version = "0.1.0", path = "../../../repo_attributes/bookmarks/dbbookmarks" }
 facet = { version = "0.1.0", git = "https://github.com/facebookexperimental/rust-shed.git", branch = "main" }
 filenodes = { version = "0.1.0", path = "../../../repo_attributes/filenodes" }
 filestore = { version = "0.1.0", path = "../../../repo_attributes/filestore" }

eden/mononoke/features/commit_rewriting/backsyncer/src/lib.rs

@@ -62,6 +62,7 @@ use cross_repo_sync::CommitSyncData;
 use cross_repo_sync::CommitSyncOutcome;
 use cross_repo_sync::find_toposorted_unsynced_ancestors;
 use cross_repo_sync::sync_commit;
+use dbbookmarks::SqlBookmarks;
 use filenodes::Filenodes;
 use filestore::FilestoreConfig;
 use futures::Future;
@@ -117,6 +118,7 @@ pub struct Repo(
     RepoCrossRepo,
     RepoBookmarkAttrs,
     dyn Bookmarks,
+    SqlBookmarks,
     dyn BookmarkUpdateLog,
     FilestoreConfig,
     dyn MutableCounters,

eden/mononoke/features/cross_repo_sync/BUCK

@@ -74,6 +74,7 @@ rust_library(
         "//eden/mononoke/repo_attributes/bonsai_globalrev_mapping:bonsai_globalrev_mapping",
         "//eden/mononoke/repo_attributes/bonsai_hg_mapping:bonsai_hg_mapping",
         "//eden/mononoke/repo_attributes/bookmarks:bookmarks",
+        "//eden/mononoke/repo_attributes/bookmarks/dbbookmarks:dbbookmarks",
         "//eden/mononoke/repo_attributes/commit_graph/commit_graph:commit_graph",
         "//eden/mononoke/repo_attributes/filenodes:filenodes",
         "//eden/mononoke/repo_attributes/filestore:filestore",

eden/mononoke/features/cross_repo_sync/Cargo.toml

@@ -26,6 +26,7 @@ commit_graph = { version = "0.1.0", path = "../../repo_attributes/commit_graph/c
 commit_transformation = { version = "0.1.0", path = "../commit_transformation/commit_transformation" }
 content_manifest_derivation = { version = "0.1.0", path = "../../derived_data/content_manifest_derivation" }
 context = { version = "0.1.0", path = "../../servers/slapi/slapi_server/context" }
+dbbookmarks = { version = "0.1.0", path = "../../repo_attributes/bookmarks/dbbookmarks" }
 derivation_queue_thrift = { version = "0.1.0", path = "../../repo_attributes/repo_derivation_queues/if" }
 either = "1.5"
 environment = { version = "0.1.0", path = "../../cmdlib/environment" }

eden/mononoke/features/cross_repo_sync/src/test_utils.rs

@@ -31,6 +31,7 @@ use commit_transformation::git_submodules::SubmoduleExpansionData;
 use commit_transformation::rewrite_commit;
 use commit_transformation::upload_commits;
 use context::CoreContext;
+use dbbookmarks::SqlBookmarks;
 use filenodes::Filenodes;
 use filestore::FilestoreConfig;
 use git_source_of_truth::GitSourceOfTruthConfig;
@@ -81,6 +82,9 @@ pub struct TestRepo {
     #[facet]
     bookmarks: dyn Bookmarks,
 
+    #[facet]
+    sql_bookmarks: SqlBookmarks,
+
     #[facet]
     bookmark_update_log: dyn BookmarkUpdateLog,
 

eden/mononoke/features/cross_repo_sync/src/types.rs

@@ -32,6 +32,8 @@ use commit_graph::CommitGraphArc;
 use commit_graph::CommitGraphRef;
 use commit_graph::CommitGraphWriter;
 use commit_graph::CommitGraphWriterRef;
+use dbbookmarks::SqlBookmarks;
+use dbbookmarks::SqlBookmarksRef;
 use filenodes::Filenodes;
 use filenodes::FilenodesArc;
 use filenodes::FilenodesRef;
@@ -177,6 +179,7 @@ pub enum PushrebaseRewriteDates {
 
 pub trait Repo = BookmarksArc
     + BookmarksRef
+    + SqlBookmarksRef
     + BookmarkUpdateLogArc
     + BookmarkUpdateLogRef
     + RepoBlobstoreArc
@@ -214,6 +217,9 @@ pub struct ConcreteRepo {
     #[facet]
     bookmarks: dyn Bookmarks,
 
+    #[facet]
+    sql_bookmarks: SqlBookmarks,
+
     #[facet]
     bookmark_update_log: dyn BookmarkUpdateLog,
 

eden/mononoke/mononoke_api/BUCK

@@ -110,6 +110,7 @@ rust_library(
         "//eden/mononoke/repo_attributes/bookmarks:bookmarks",
         "//eden/mononoke/repo_attributes/bookmarks/bookmarks_cache:bookmarks_cache",
         "//eden/mononoke/repo_attributes/bookmarks/bookmarks_movement:bookmarks_movement",
+        "//eden/mononoke/repo_attributes/bookmarks/dbbookmarks:dbbookmarks",
         "//eden/mononoke/repo_attributes/commit_graph/commit_graph:commit_graph",
         "//eden/mononoke/repo_attributes/commit_graph/sql_commit_graph_storage:sql_commit_graph_storage",
         "//eden/mononoke/repo_attributes/commit_rate_limit:commit_rate_limit_config",

eden/mononoke/mononoke_api/Cargo.toml

@@ -40,6 +40,7 @@ commit_rate_limit_config = { version = "0.1.0", path = "../repo_attributes/commi
 content_manifest_derivation = { version = "0.1.0", path = "../derived_data/content_manifest_derivation" }
 context = { version = "0.1.0", path = "../servers/slapi/slapi_server/context" }
 cross_repo_sync = { version = "0.1.0", path = "../features/cross_repo_sync" }
+dbbookmarks = { version = "0.1.0", path = "../repo_attributes/bookmarks/dbbookmarks" }
 deleted_manifest = { version = "0.1.0", path = "../derived_data/deleted_manifest" }
 derivation_queue_thrift = { version = "0.1.0", path = "../repo_attributes/repo_derivation_queues/if" }
 derivative = "2.2"

eden/mononoke/mononoke_api/src/repo.rs

@@ -74,6 +74,7 @@ use cross_repo_sync::get_all_submodule_deps_from_repo_pair;
 use cross_repo_sync::get_small_and_large_repos;
 use cross_repo_sync::sync_commit;
 use dag_types::Location;
+use dbbookmarks::SqlBookmarks;
 use derivation_queue_thrift::DerivationPriority;
 use derived_data_manager::BonsaiDerivable;
 use derived_data_manager::DerivableType;
@@ -263,6 +264,9 @@ pub struct Repo {
     #[facet]
     pub bookmarks: dyn Bookmarks,
 
+    #[facet]
+    pub sql_bookmarks: SqlBookmarks,
+
     #[facet]
     pub phases: dyn Phases,