telemetry: Move Thrift timeouts and limits to EdenConfig

Summary: Move XPlatLogger timeout and maximums to EdenConfig so that we can update the numbers without having to generate a new binary.

Reviewed By: kavehahmadi60

Differential Revision: D101873970

fbshipit-source-id: 8f5c7a4ebc9e4704dcd79f0508730cb4593d8ce2

Author: janezhang10

eden/fs/config/EdenConfig.h

@@ -2366,6 +2366,38 @@ class EdenConfig : private ConfigSettingManager {
       RelativePath{".edenfs-notifications-state"},
       this};
 
+  // [xplat-logger]
+
+  ConfigSetting<size_t> xplatLoggerQueueLimitBytes{
+      "xplat-logger:queue-limit-bytes",
+      128 * 1024,
+      this};
+
+  ConfigSetting<size_t> xplatLoggerMaxBatchSize{
+      "xplat-logger:max-batch-size",
+      100,
+      this};
+
+  ConfigSetting<size_t> xplatLoggerMaxConsecutiveFailures{
+      "xplat-logger:max-consecutive-failures",
+      3,
+      this};
+
+  ConfigSetting<std::chrono::nanoseconds> xplatLoggerFlushTimeout{
+      "xplat-logger:flush-timeout",
+      std::chrono::seconds(1),
+      this};
+
+  ConfigSetting<std::chrono::nanoseconds> xplatLoggerConnectTimeout{
+      "xplat-logger:connect-timeout",
+      std::chrono::seconds(1),
+      this};
+
+  ConfigSetting<std::chrono::nanoseconds> xplatLoggerRpcTimeout{
+      "xplat-logger:rpc-timeout",
+      std::chrono::seconds(1),
+      this};
+
 // [facebook]
 // Facebook internal
 

eden/fs/inodes/test/InodeAccessLoggerDualWriteTest.cpp

@@ -40,12 +40,17 @@ class SpyStructuredLogger : public StructuredLogger {
   }
 };
 
+std::shared_ptr<ReloadableConfig> makeTestReloadableConfig() {
+  return std::make_shared<ReloadableConfig>(EdenConfig::createTestEdenConfig());
+}
+
 class SpyXplatLogger : public XplatLogger {
  public:
   SpyXplatLogger()
       : XplatLogger(
             EdenTelemetryIdentity{},
-            makeRefPtr<EdenStats>()) {}
+            makeRefPtr<EdenStats>(),
+          makeTestReloadableConfig()) {}
 
   std::atomic<int> callCount{0};
   folly::SaturatingSemaphore<> eventLogged;

eden/fs/service/EdenServer.cpp

@@ -568,7 +568,8 @@ EdenServer::EdenServer(
 #ifdef EDEN_HAVE_LOGGER
       xplatLogger_{std::make_unique<XplatLogger>(
           EdenTelemetryIdentity::fromSessionInfo(sessionInfo),
-          edenStats.copy())},
+          edenStats.copy(),
+          config_)},
 #endif
       serverState_{make_shared<ServerState>(
           std::move(userInfo),

eden/fs/telemetry/test/BUCK

@@ -56,10 +56,17 @@ cpp_benchmark(
     ),
     deps = [
         "fbsource//third-party/benchmark:benchmark",
-        "//eden/common/telemetry:telemetry",
-        "//eden/common/utils/benchharness:benchharness",
+        "//eden/common/telemetry:log_info",
+        "//eden/common/telemetry:scribe_logger",
+        "//eden/common/utils:ref_ptr",
+        "//eden/fs/telemetry:stats",
+        "//eden/fs/telemetry:xplat_keys",
+        "//eden/fs/telemetry/facebook:XplatTransforms",
+        "//eden/fs/telemetry/facebook:eden_telemetry_identity",
+        "//eden/fs/telemetry/facebook:xplat_logger",
         "//folly/init:init",
-        "//folly/synchronization/test:barrier",
+        "//folly/json:dynamic",
+        "//scribe/api/producer/structured:compact_message",
     ],
 )
 

eden/fs/telemetry/test/LoggingBenchmark.cpp

@@ -192,8 +192,8 @@ static void BM_XplatLogger_Enqueue(benchmark::State& state) {
 
   if (state.thread_index() == 0) {
     teardownCount.store(0, std::memory_order_relaxed);
-    ownedLogger =
-        std::make_unique<XplatLogger>(makeIdentity(), makeRefPtr<EdenStats>());
+    ownedLogger = std::make_unique<XplatLogger>(
+        makeIdentity(), makeRefPtr<EdenStats>(), nullptr);
     ownedLogger->registerTransform(
         "perfpipe_edenfs_file_accesses",
         "GeneratedEdenfsFileAccessesLoggerConfig",
@@ -250,8 +250,8 @@ BENCHMARK(BM_ScribeCat_Throughput)->Arg(100)->Arg(1000)->Arg(10000);
 
 static void BM_XplatLogger_Throughput(benchmark::State& state) {
   const auto burstSize = state.range(0);
-  auto logger =
-      std::make_unique<XplatLogger>(makeIdentity(), makeRefPtr<EdenStats>());
+  auto logger = std::make_unique<XplatLogger>(
+      makeIdentity(), makeRefPtr<EdenStats>(), nullptr);
   logger->registerTransform(
       "perfpipe_edenfs_file_accesses",
       "GeneratedEdenfsFileAccessesLoggerConfig",