Skip to content

Commit 50de54f

Browse files
r-barnesmeta-codesync[bot]
authored andcommitted
Bump getdeps patchelf from 0.10 to 0.18.0; remove pip workaround
Summary: - Updates `build/fbcode_builder/manifests/patchelf` from 0.10 → 0.18.0 - Removes the `pip install patchelf>=0.18` workaround from `tools/wheels/build_linux_sdk.sh` ## Root cause `packaging_linux` was failing with: ``` OSError: /usr/local/lib/librebalancer.so: ELF load command address/offset not page-aligned ``` `fixup-dyn-deps` builds and uses **its own patchelf binary** from the getdeps manifest — it hard-codes the absolute path to its own build in `/tmp/fbcode_builder_getdeps-.../installed/patchelf-.../bin/patchelf` and never consults PATH. The manifest was pinned to patchelf 0.10, which corrupts ELF segment alignment when rewriting RPATH on large shared libs. The dynamic loader (`dlopen`) is stricter than the static linker, so the corruption passed the link test but failed at runtime. The previous attempt to fix this (`pip install patchelf>=0.18` in `build_linux_sdk.sh`) only affected the explicit `patchelf` calls in the bash script, not the getdeps-internal binary. Updating the manifest is the correct fix. X-link: facebookincubator/rebalancer#1 Reviewed By: sahilsd Differential Revision: D108232802 Pulled By: r-barnes fbshipit-source-id: 38984c1eac0c19f01ea1f7dfd2e556967db6c27a
1 parent d066df9 commit 50de54f

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

build/fbcode_builder/manifests/patchelf

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,9 @@ patchelf
1111
patchelf
1212

1313
[download]
14-
url = https://github.com/NixOS/patchelf/archive/0.10.tar.gz
15-
sha256 = b3cb6bdedcef5607ce34a350cf0b182eb979f8f7bc31eae55a93a70a3f020d13
14+
url = https://github.com/NixOS/patchelf/archive/0.18.0.tar.gz
15+
sha256 = 1451d01ee3a21100340aed867d0b799f46f0b1749680028d38c3f5d0128fb8a7
1616

1717
[build]
1818
builder = autoconf
19-
subdir = patchelf-0.10
20-
19+
subdir = patchelf-0.18.0

0 commit comments

Comments
 (0)