Commit 50de54f
Bump getdeps patchelf from 0.10 to 0.18.0; remove pip workaround
Summary:
- Updates `build/fbcode_builder/manifests/patchelf` from 0.10 → 0.18.0
- Removes the `pip install patchelf>=0.18` workaround from `tools/wheels/build_linux_sdk.sh`
## Root cause
`packaging_linux` was failing with:
```
OSError: /usr/local/lib/librebalancer.so: ELF load command address/offset not page-aligned
```
`fixup-dyn-deps` builds and uses **its own patchelf binary** from the getdeps manifest — it hard-codes the absolute path to its own build in `/tmp/fbcode_builder_getdeps-.../installed/patchelf-.../bin/patchelf` and never consults PATH. The manifest was pinned to patchelf 0.10, which corrupts ELF segment alignment when rewriting RPATH on large shared libs. The dynamic loader (`dlopen`) is stricter than the static linker, so the corruption passed the link test but failed at runtime.
The previous attempt to fix this (`pip install patchelf>=0.18` in `build_linux_sdk.sh`) only affected the explicit `patchelf` calls in the bash script, not the getdeps-internal binary. Updating the manifest is the correct fix.
X-link: facebookincubator/rebalancer#1
Reviewed By: sahilsd
Differential Revision: D108232802
Pulled By: r-barnes
fbshipit-source-id: 38984c1eac0c19f01ea1f7dfd2e556967db6c27a1 parent d066df9 commit 50de54f
1 file changed
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
| 14 | + | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
| 19 | + | |
0 commit comments