Add ObjectStore::co_getDigestHash

Summary: Complete getDigestHash coroutine migration by adding ObjectStore.co_getDigestHash.

Reviewed By: SBones

Differential Revision: D105636960

fbshipit-source-id: afc0385968fb09daafe48dcfe3d732b4a7def73f

Author: janezhang10

eden/fs/inodes/TreeInode.cpp

@@ -1948,9 +1948,8 @@ folly::coro::now_task<std::optional<Hash32>> TreeInode::co_getDigestHash(
     treeId = state->treeId.value();
   }
   // ObjectStore::getTreeDigestHash has no co_ version yet, bridge via .semi()
-  co_return co_await getObjectStore()
-      .getTreeDigestHash(treeId, fetchContext)
-      .semi();
+  co_return co_await getObjectStore().co_getTreeDigestHash(
+      treeId, fetchContext);
 }
 
 ImmediateFuture<std::optional<uint64_t>> TreeInode::getDigestSize(

eden/fs/inodes/VirtualInode.cpp

@@ -272,17 +272,14 @@ folly::coro::now_task<std::optional<Hash32>> VirtualInode::co_getDigestHash(
   } else if (
       auto* entry =
           std::get_if<UnmaterializedUnloadedBlobDirEntry>(&variant_)) {
-    co_return co_await objectStore
-        ->getTreeDigestHash(entry->getObjectId(), fetchContext)
-        .semi();
+    co_return co_await objectStore->co_getTreeDigestHash(
+        entry->getObjectId(), fetchContext);
   } else if (auto* tree = std::get_if<TreePtr>(&variant_)) {
-    co_return co_await objectStore
-        ->getTreeDigestHash((*tree)->getObjectId(), fetchContext)
-        .semi();
+    co_return co_await objectStore->co_getTreeDigestHash(
+        (*tree)->getObjectId(), fetchContext);
   } else if (auto* treeEntry = std::get_if<TreeEntry>(&variant_)) {
-    co_return co_await objectStore
-        ->getTreeDigestHash(treeEntry->getObjectId(), fetchContext)
-        .semi();
+    co_return co_await objectStore->co_getTreeDigestHash(
+        treeEntry->getObjectId(), fetchContext);
   } else {
     co_yield folly::coro::co_error(PathError(
         EINVAL, path, std::string_view{"variant is of unhandled type"}));

eden/fs/store/ObjectStore.cpp

@@ -517,6 +517,13 @@ ImmediateFuture<std::optional<Hash32>> ObjectStore::getTreeDigestHash(
           });
 }
 
+folly::coro::now_task<std::optional<Hash32>> ObjectStore::co_getTreeDigestHash(
+    const ObjectId& id,
+    const ObjectFetchContextPtr& context) const {
+  auto auxData = co_await co_getTreeAuxData(id, context);
+  co_return auxData.has_value() ? auxData->digestHash : std::nullopt;
+}
+
 ImmediateFuture<std::optional<uint64_t>> ObjectStore::getTreeDigestSize(
     const ObjectId& id,
     const ObjectFetchContextPtr& context) const {

eden/fs/store/ObjectStore.h

@@ -251,11 +251,17 @@ class ObjectStore : public IObjectStore,
 
   /**
    * Returns the DigestHash hash of the contents of the tree with the given ID.
+   *
+   * DEPRECATED: Use co_getTreeDigestHash instead.
    */
   ImmediateFuture<std::optional<Hash32>> getTreeDigestHash(
       const ObjectId& id,
       const ObjectFetchContextPtr& context) const;
 
+  folly::coro::now_task<std::optional<Hash32>> co_getTreeDigestHash(
+      const ObjectId& id,
+      const ObjectFetchContextPtr& context) const;
+
   /**
    * Returns the digest size of the tree with the given ID.
    */