Fix takeover recovery test teardown under TSan

Summary: Drive the recovered thrift server in the takeover recovery tests before tearing down the `EdenServer`. `performCleanup()` returns false after a failed takeover and relies on the main Eden loop to call `serve()` again so `createThriftServer()` can complete. The tests were skipping that production step, leaving detached recovery work live during object destruction.

Reviewed By: genevievehelsel

Differential Revision: D116107409

fbshipit-source-id: 72f2560d90f832d8b2130c39ad9c7035476af2a0

Author: janezhang10

eden/fs/service/test/EdenServerTest.cpp

@@ -340,7 +340,11 @@ TEST_F(EdenServerTest, TakeoverSendFailureRecoversDuringCleanup) {
   auto originalHandler = server.getHandler();
   ASSERT_NO_FATAL_FAILURE(
       driveTakeoverSendFailureToCleanup(testServer(), server));
-  EXPECT_FALSE(server.performCleanup());
+  ASSERT_FALSE(server.performCleanup());
+  ScopedServerThread serverThread{server};
+  ASSERT_TRUE(driveMainEventBaseUntil(server, [&] {
+    return server.getStatus() == EdenServer::RunState::RUNNING;
+  }));
   EXPECT_NE(originalHandler, server.getHandler());
 }
 
@@ -354,6 +358,11 @@ TEST_F(EdenServerTest, TakeoverSendFailureRecoveryReinitializesMountd) {
       driveTakeoverSendFailureToCleanup(nfsTestServer, server));
   ASSERT_FALSE(server.performCleanup());
 
+  ScopedServerThread serverThread{server};
+  ASSERT_TRUE(driveMainEventBaseUntil(server, [&] {
+    return server.getStatus() == EdenServer::RunState::RUNNING;
+  }));
+
   std::thread recoveryEventBaseThread(
       [&server] { server.getMainEventBase()->loop(); });
   auto stopRecoveryLoop = folly::makeGuard([&] {