From 7ecf5801c604f383a7129d864b09cb97bdf91d54 Mon Sep 17 00:00:00 2001 From: Andy Li Date: Fri, 17 Jan 2025 14:33:11 -0800 Subject: [PATCH] Fix wording of goto off warm warning Summary: Wording of this warning was confusing before. Changing it to better reflect what it's warning users from (warning about using Goto rather than rebasing) Reviewed By: evangrayk Differential Revision: D68338444 fbshipit-source-id: a44ed1bf2ac40b1dd1fc81c8fd07c52bb10f4ec8 --- addons/isl/src/Commit.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/isl/src/Commit.tsx b/addons/isl/src/Commit.tsx index 570e77115a978..e8c3cbaa392f9 100644 --- a/addons/isl/src/Commit.tsx +++ b/addons/isl/src/Commit.tsx @@ -727,11 +727,11 @@ async function maybeWarnAboutRebaseOffWarm(dest: CommitInfo): Promise { ); if (await warning) { tracker.track('WarnAboutRebaseOffWarm'); - const buttons = [t('Opt Out of Future Warnings'), t('Cancel'), t('Rebase Anyway')]; + const buttons = [t('Opt Out of Future Warnings'), t('Cancel'), t('Goto Anyway')]; const answer = await showModal({ type: 'confirm', buttons, - title: Rebase off Warm Commit, + title: Move off Warm Commit, message: t( Internal.warnAboutRebaseOffWarmReason ?? "The commit you're on is a warmed up commit. Moving off will cause slower builds and performance.\n" +