add submit button for single commits

Summary:
Adds a submit button for single commits. This will only appear for commits that:

* Are not in a stack
* Are not associated with a diff

Reviewed By: nsblake

Differential Revision: D91435490

fbshipit-source-id: f7c99ccce6aab63e67b079615fe3bda25f735617

Author: alexchantastic

addons/isl-server/src/analytics/eventNames.ts

@@ -152,6 +152,7 @@ export type TrackEventName =
   | 'SplitOpenFromHeadCommit'
   | 'SplitOpenFromSmartActions'
   | 'SplitOpenRangeSelector'
+  | 'SubmitSingleCommit'
   | 'AISplitButtonClick'
   | 'SuccessionsDetected'
   | 'BuggySuccessionDetected'

addons/isl/src/Commit.tsx

@@ -35,6 +35,7 @@ import {EducationInfoTip} from './Education';
 import {HighlightCommitsWhileHovering} from './HighlightedCommits';
 import {Internal} from './Internal';
 import {SubmitSelectionButton} from './SubmitSelectionButton';
+import {SubmitSingleCommitButton} from './SubmitSingleCommitButton';
 import {getSuggestedRebaseOperation, suggestedRebaseDestinations} from './SuggestedRebase';
 import {UncommitButton} from './UncommitButton';
 import {UncommittedChanges} from './UncommittedChanges';
@@ -436,8 +437,10 @@ export const Commit = memo(
     }
 
     if (!isPublic && !actionsPrevented && commit.isDot && !inConflicts) {
+      commitActions.push(<SubmitSingleCommitButton key="submit" />);
       commitActions.push(<UncommitButton key="uncommit" />);
     }
+
     if (!isPublic && !actionsPrevented && commit.isDot && !isObsoleted && !inConflicts) {
       commitActions.push(
         <SplitButton icon key="split" trackerEventName="SplitOpenFromHeadCommit" commit={commit} />,

addons/isl/src/SubmitSingleCommitButton.tsx

@@ -0,0 +1,66 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+import {Button} from 'isl-components/Button';
+import {Icon} from 'isl-components/Icon';
+import {DOCUMENTATION_DELAY, Tooltip} from 'isl-components/Tooltip';
+import {useAtomValue} from 'jotai';
+import {tracker} from './analytics';
+import {codeReviewProvider, diffSummary} from './codeReview/CodeReviewInfo';
+import {submitAsDraft} from './codeReview/DraftCheckbox';
+import {t, T} from './i18n';
+import {readAtom} from './jotaiUtils';
+import {useRunOperation} from './operationsState';
+import {dagWithPreviews} from './previews';
+
+export function SubmitSingleCommitButton() {
+  const dag = useAtomValue(dagWithPreviews);
+  const headCommit = dag.resolve('.');
+
+  const provider = useAtomValue(codeReviewProvider);
+  const diff = useAtomValue(diffSummary(headCommit?.diffId));
+  const isClosed = provider != null && diff.value != null && provider?.isDiffClosed(diff.value);
+
+  const runOperation = useRunOperation();
+
+  if (!headCommit || !provider) {
+    return null;
+  }
+
+  const draftAncestors = dag.ancestors(headCommit.hash, {within: dag.draft()});
+  const isSingleCommit = draftAncestors.size === 1;
+  const hasDiff = headCommit.diffId !== undefined;
+
+  if (!isSingleCommit || isClosed || hasDiff) {
+    return null;
+  }
+
+  const tooltip = t('Submit this commit for review with $cmd.', {
+    replace: {$cmd: provider.submitCommandName()},
+  });
+
+  return (
+    <Tooltip delayMs={DOCUMENTATION_DELAY} title={tooltip}>
+      <Button
+        onClick={e => {
+          e.stopPropagation();
+          tracker.track('SubmitSingleCommit');
+          const draft = readAtom(submitAsDraft);
+          runOperation(
+            provider.submitOperation([], {
+              draft: draft ?? false,
+            }),
+          );
+        }}
+        icon
+        data-testid="submit-button">
+        <Icon icon="cloud-upload" slot="start" />
+        <T>Submit</T>
+      </Button>
+    </Tooltip>
+  );
+}