Skip to content

Commit d364d24

Browse files
evangraykmeta-codesync[bot]
authored andcommitted
Make goto and open commit buttons icon-style
Summary: The styling on these buttons changed recently-ish. They don't match the other ISL buttons and look out of place. On web it also looked unreadable in light themes due to a fg color mismatch. Let's just use icon buttons for consistency. Reviewed By: muirdm Differential Revision: D116701714 fbshipit-source-id: ba9a3a86a9b7b4d5f65b7af9ef5b703b15602277
1 parent 5e3f347 commit d364d24

2 files changed

Lines changed: 1 addition & 5 deletions

File tree

addons/isl/src/Commit.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -655,6 +655,7 @@ export const Commit = memo(
655655
)}
656656
delayMs={250}>
657657
<Button
658+
icon
658659
aria-label={t('Go to commit "$title"', {replace: {$title: commit.title}})}
659660
className={css.gotoButton}
660661
onClick={async event => {

addons/isl/src/CommitTreeList.css

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -305,11 +305,6 @@
305305
transition: opacity 0.1s;
306306
}
307307

308-
.goto-button button,
309-
.open-commit-info-button {
310-
background-color: var(--background);
311-
}
312-
313308
.commit:hover .goto-button,
314309
.commit:hover .open-commit-info-button {
315310
opacity: 1;

0 commit comments

Comments
 (0)