Commit e4f7cec
Ship edenfsctl.pdb in the Windows package
Summary:
The `nupkg.fb-eden-windows` package ships the daemon's symbols (`edenfs.pdb`) but not the Rust CLI's (`edenfsctl.pdb`). While analyzing the current corp-wide edenfsctl crash cluster (fastfail aborts on the CLI's folly IOThreadPool during `eden list --json`), this blocked symbolized crash analysis: contbuild binaries aren't locally reproducible, so the debug ID in crash dumps can't be matched to a locally-built PDB.
Add the CLI PDB the same way the daemon's is handled:
- `build_targets.bzl`: add the `edenfsctl[pdb]` subtarget to `EDENFS_WINDOWS_DEPS`, mirroring the existing `service:edenfs[pdb]` entry
- `chocolateyinstall.ps1`: copy `edenfsctl.pdb` from deps/ to the libexec folder next to `edenfsctl.exe`, so DbgHelp-based tools on user machines resolve symbols automatically (same reason `edenfs.pdb` is installed today)
With this, dumps from any release become symbolizable by fetching the matching package.
Size impact: `edenfsctl.pdb` is ~604MB uncompressed, ~120MB compressed in the nupkg (the existing `edenfs.pdb` is 1.69GB uncompressed / 327MB compressed). Install adds ~604MB on disk alongside the existing 1.7GB `edenfs.pdb`.
The uninstall script removes the whole eden folder recursively, so no uninstall changes are needed. The lint copyright header on `chocolateyinstall.ps1` was added by `arc lint --apply-patches`.
Reviewed By: muirdm
Differential Revision: D116694402
fbshipit-source-id: 8ea8c1ea27b7ec6a24ff29d41931f302e26323471 parent 634c7a7 commit e4f7cec
1 file changed
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| 65 | + | |
65 | 66 | | |
66 | 67 | | |
67 | 68 | | |
| |||
0 commit comments