Skip to content

Commit e4f7cec

Browse files
MichaelCuevasmeta-codesync[bot]
authored andcommitted
Ship edenfsctl.pdb in the Windows package
Summary: The `nupkg.fb-eden-windows` package ships the daemon's symbols (`edenfs.pdb`) but not the Rust CLI's (`edenfsctl.pdb`). While analyzing the current corp-wide edenfsctl crash cluster (fastfail aborts on the CLI's folly IOThreadPool during `eden list --json`), this blocked symbolized crash analysis: contbuild binaries aren't locally reproducible, so the debug ID in crash dumps can't be matched to a locally-built PDB. Add the CLI PDB the same way the daemon's is handled: - `build_targets.bzl`: add the `edenfsctl[pdb]` subtarget to `EDENFS_WINDOWS_DEPS`, mirroring the existing `service:edenfs[pdb]` entry - `chocolateyinstall.ps1`: copy `edenfsctl.pdb` from deps/ to the libexec folder next to `edenfsctl.exe`, so DbgHelp-based tools on user machines resolve symbols automatically (same reason `edenfs.pdb` is installed today) With this, dumps from any release become symbolizable by fetching the matching package. Size impact: `edenfsctl.pdb` is ~604MB uncompressed, ~120MB compressed in the nupkg (the existing `edenfs.pdb` is 1.69GB uncompressed / 327MB compressed). Install adds ~604MB on disk alongside the existing 1.7GB `edenfs.pdb`. The uninstall script removes the whole eden folder recursively, so no uninstall changes are needed. The lint copyright header on `chocolateyinstall.ps1` was added by `arc lint --apply-patches`. Reviewed By: muirdm Differential Revision: D116694402 fbshipit-source-id: 8ea8c1ea27b7ec6a24ff29d41931f302e2632347
1 parent 634c7a7 commit e4f7cec

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

eden/fs/build_targets.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ EDENFS_WINDOWS_DEPS = [
6262
"fbcode//eden/fs/cli:edenfsctl",
6363
"fbcode//eden/fs/cli/trace:trace_stream",
6464
"fbcode//eden/fs/cli_rs/edenfsctl:edenfsctl",
65+
"fbcode//eden/fs/cli_rs/edenfsctl:edenfsctl[pdb]",
6566
"fbcode//eden/fs/config/facebook:edenfs_config_manager",
6667
"fbcode//eden/fs/config/facebook/config_manager_rs:edenfs_config_manager_rust",
6768
"fbcode//eden/fs/facebook:eden-fb303-collector",

0 commit comments

Comments
 (0)