telemetry: Guard OBC counters for OSS builds

Summary: Add an OSS `eden-config.h` variant and make the OBC includes, counters, and update paths conditional on `EDEN_HAVE_OBC`. Internal builds keep defining `EDEN_HAVE_OBC`, while the shipped OSS config can omit the internal OBC dependency.

Reviewed By: muirdm

Differential Revision: D109885413

fbshipit-source-id: 6512c468f7dbe808f334ab03fade34cd4adf5278

Author: genevievehelsel

eden/fs/service/EdenServer.cpp

@@ -1351,6 +1351,7 @@ Future<TakeoverData> EdenServer::stopMountsForTakeover(
 
 void EdenServer::startPeriodicTasks() {
   auto config = serverState_->getReloadableConfig()->getEdenConfig();
+#ifdef EDEN_HAVE_OBC
   if (config->enableOBCOnEden.getValue()) {
     // Get the hostname without the ".facebook.com" suffix
     auto hostname = facebook::network::getLocalHost(/*stripFbDomain=*/true);
@@ -1368,6 +1369,7 @@ void EdenServer::startPeriodicTasks() {
     // Report memory usage stats once every 60 seconds
     memoryStatsTask_.updateInterval(60s);
   }
+#endif
   updatePeriodicTaskIntervals(*config);
 
 #ifndef _WIN32
@@ -3202,11 +3204,13 @@ void EdenServer::flushStatsNow() {
 }
 
 void EdenServer::reportMemoryStats() {
+#ifdef EDEN_HAVE_OBC
   auto memoryStats = facebook::eden::proc_util::readMemoryStats();
   if (memoryStats) {
     // Bump the OBC counters for the current memory usage
     memory_vm_rss_bytes_ += memoryStats->resident;
   }
+#endif
 }
 
 void EdenServer::refreshBackingStore() {

eden/fs/service/EdenServer.h

@@ -46,7 +46,9 @@
 #include "eden/fs/takeover/TakeoverHandler.h"
 #include "eden/fs/telemetry/EdenStats.h"
 #include "eden/fs/telemetry/IActivityRecorder.h"
+#ifdef EDEN_HAVE_OBC
 #include "monitoring/obc/OBCAvg.h"
+#endif
 
 DECLARE_bool(takeover);
 
@@ -607,8 +609,10 @@ class EdenServer : private TakeoverHandler {
   void startPeriodicTasks();
   void updatePeriodicTaskIntervals(const EdenConfig& config);
 
-  // calculates eden rss memory usage
+#ifdef EDEN_HAVE_OBC
+  // Calculates EdenFS RSS memory usage.
   monitoring::OBCAvg memory_vm_rss_bytes_;
+#endif
 
   /**
    * Schedule a call to unloadInodes() to happen after timeout

eden/fs/store/sl/SaplingBackingStore.cpp

@@ -54,7 +54,9 @@
 #ifdef EDEN_HAVE_SERVER_OBSERVER
 #include "common/fb303/cpp/ThreadPoolExecutorCounters.h" // @manual
 #endif
+#ifdef EDEN_HAVE_OBC
 #include "common/network/Hostname.h"
+#endif
 
 DEFINE_bool(
     hg_fetch_missing_trees,
@@ -176,9 +178,11 @@ SaplingBackingStore::SaplingBackingStore(
       folly::to<std::string>("hg-activitybuffer-", getRepoName().value_or("")),
       [this](const HgImportTraceEvent& event) { this->processHgEvent(event); });
 
+#ifdef EDEN_HAVE_OBC
   if (config_->getEdenConfig()->enableOBCOnEden.getValue()) {
     initializeOBCCounters();
   }
+#endif
 }
 
 /**
@@ -251,9 +255,11 @@ SaplingBackingStore::SaplingBackingStore(
       folly::to<std::string>("hg-activitybuffer-", getRepoName().value_or("")),
       [this](const HgImportTraceEvent& event) { this->processHgEvent(event); });
 
+#ifdef EDEN_HAVE_OBC
   if (config_->getEdenConfig()->enableOBCOnEden.getValue()) {
     initializeOBCCounters();
   }
+#endif
 }
 
 SaplingBackingStore::~SaplingBackingStore() {
@@ -263,6 +269,7 @@ SaplingBackingStore::~SaplingBackingStore() {
   }
 }
 
+#ifdef EDEN_HAVE_OBC
 void SaplingBackingStore::initializeOBCCounters() {
   // Get the hostname without the ".facebook.com" suffix
   auto hostname = facebook::network::getLocalHost(/*stripFbDomain=*/true);
@@ -276,6 +283,7 @@ void SaplingBackingStore::initializeOBCCounters() {
       {hostname});
   isOBCEnabled_ = true;
 }
+#endif
 
 void SaplingBackingStore::processHgEvent(const HgImportTraceEvent& event) {
   switch (event.eventType) {
@@ -331,9 +339,11 @@ void SaplingBackingStore::setFetchBlobCounters(
     return;
   }
 
+#ifdef EDEN_HAVE_OBC
   if (isOBCEnabled_) {
     getBlobPerRepoLatencies_ += watch.elapsed().count();
   }
+#endif
   stats_->addDuration(&SaplingBackingStoreStats::fetchBlob, watch.elapsed());
 
   if (fetchResult == ObjectFetchContext::FetchResult::Success) {
@@ -586,9 +596,11 @@ void SaplingBackingStore::getTreeBatch(
       }
     }
 
+#ifdef EDEN_HAVE_OBC
     if (isOBCEnabled_) {
       getTreePerRepoLatencies_ += batchWatch.elapsed().count();
     }
+#endif
     stats_->addDuration(
         &SaplingBackingStoreStats::fetchTree, batchWatch.elapsed());
 

eden/fs/store/sl/SaplingBackingStore.h

@@ -31,7 +31,9 @@
 #include "eden/fs/store/sl/SaplingImportRequestQueue.h"
 #include "eden/fs/telemetry/ActivityBuffer.h"
 #include "eden/scm/lib/backingstore/src/ffi.rs.h"
+#ifdef EDEN_HAVE_OBC
 #include "monitoring/obc/OBCPxx.h"
+#endif
 
 namespace sapling {
 using NodeId = facebook::eden::Hash20;
@@ -765,13 +767,15 @@ class SaplingBackingStore final
 
   EdenStatsPtr stats_;
 
+#ifdef EDEN_HAVE_OBC
   // This is used to avoid reading config in hot path of get request
   bool isOBCEnabled_ = false;
   // TODO: this is a prototype to test OBC API on eden
   // we should move these to a separate class
   monitoring::OBCP99P95P50 getBlobPerRepoLatencies_; // calculates p50, p95, p99
   monitoring::OBCP99P95P50 getTreePerRepoLatencies_; // calculates p50, p95, p99
   void initializeOBCCounters();
+#endif
 
   bool dogfoodingHost();