transaction: skip lock-free journal undo

Summary: Lock-free transactions do not own `journal*` files, so do not move them to undo files.

Reviewed By: quark-zju

Differential Revision: D109166273

fbshipit-source-id: 21c12ead3de520d12df1541a3ef9373c69a8534c

Author: zzl0

eden/scm/sapling/localrepo.py

@@ -1790,9 +1790,12 @@ def transaction(self, desc, report=None, lockfree=False):
         txnid = "TXN:" + ha
         self.hook("pretxnopen", throw=True, txnname=desc, txnid=txnid)
 
+        # Lock-free transactions do not create fixed journal files.
         if not lockfree:
             self._writejournal(desc)
-        renames = [(vfs, x, undoname(x)) for vfs, x in self._journalfiles()]
+            renames = [(vfs, x, undoname(x)) for vfs, x in self._journalfiles()]
+        else:
+            renames = []
         if report:
             rp = report
         else:

eden/scm/tests/test-transaction-missing-journal-dirstate.t

@@ -38,5 +38,3 @@ Lock-free transaction close must not move another transaction's journals.
   $ touch $TESTTMP/go
   $ wait
   $ cat $TESTTMP/out
-  abort: $ENOENT$: $TESTTMP/repo/.sl/journal.dirstate (no-windows !)
-  abort: $TESTTMP\repo\.sl\journal.dirstate: $ENOENT$. (windows !)