Update shlex from 1.3.0 to 2.0.1

Summary:
Release notes:
https://github.com/comex/rust-shlex/blob/master/CHANGELOG.md

Reviewed By: 8Keep

Differential Revision: D116823414

fbshipit-source-id: c58a7a8325118b30b1218a503e3eaaef6e82e451

Author: David Tolnay

eden/fs/cli_rs/edenfs-client/Cargo.toml

@@ -34,7 +34,7 @@ sapling-http-client = { version = "0.1.0", path = "../../../scm/lib/http-client"
 sapling-thrift-types = { version = "0.1.0", path = "../../../scm/lib/thrift-types" }
 serde = { version = "1.0.229", features = ["derive", "rc"] }
 serde_json = { version = "1.0.151", features = ["alloc", "float_roundtrip", "raw_value", "unbounded_depth"] }
-shlex = "1.3"
+shlex = "2.0.1"
 strum = { version = "0.28.0", features = ["derive"] }
 subprocess = "0.2.15"
 sysinfo = "0.38.4"

eden/fs/cli_rs/edenfs-client/src/redirect.rs

@@ -484,7 +484,7 @@ impl Redirection {
                 format!(
                     "Failed to execute command `{} {}`",
                     APFS_HELPER,
-                    shlex::join(args.iter().copied())
+                    shlex::try_join(args.iter().copied()).unwrap(), // Unwrap OK, we know the args are valid
                 )
             })?;
         if output.status.success() {
@@ -551,7 +551,7 @@ impl Redirection {
                 .with_context(|| {
                     format!(
                         "Failed to execute command `hdiutil {}`",
-                        shlex::join(args.iter().copied())
+                        shlex::try_join(args.iter().copied()).unwrap(), // Unwrap OK, we know the args are valid
                     )
                 })?;
             if !create_output.status.success() {
@@ -589,7 +589,7 @@ impl Redirection {
             .with_context(|| {
                 format!(
                     "Failed to execute command `hdiutil {}`",
-                    shlex::join(args.iter().copied())
+                    shlex::try_join(args.iter().copied()).unwrap(), // Unwrap OK, we know the args are valid
                 )
             })?;
         if !attach_output.status.success() {
@@ -713,7 +713,7 @@ impl Redirection {
                 .with_context(|| {
                     format!(
                         "Failed to execute command `diskutil {}`",
-                        shlex::join(args.iter().copied())
+                        shlex::try_join(args.iter().copied()).unwrap(), // Unwrap OK, we know the args are valid
                     )
                 })?;
             if !output.status.success() {

eden/fs/cli_rs/edenfs-commands/Cargo.toml

@@ -51,8 +51,8 @@ tracing = { version = "0.1.41", features = ["attributes", "valuable"] }
 tempfile = "3.27.0"
 
 [target.'cfg(target_os = "linux")'.dependencies]
-shlex = "1.3"
+shlex = "2.0.1"
 
 [target.'cfg(target_os = "macos")'.dependencies]
 glob = "0.3.4"
-shlex = "1.3"
+shlex = "2.0.1"

eden/fs/cli_rs/edenfs-commands/src/redirect.rs

@@ -568,7 +568,7 @@ impl RedirectCmd {
                         format!(
                             "Failed to execute apfs_helper cmd: `{} {}`.",
                             APFS_HELPER,
-                            shlex::join(args.iter().copied()),
+                            shlex::try_join(args.iter().copied()).unwrap(), // Unwrap OK, we know the args are valid
                         )
                     })?;
                 if !output.status.success() {

eden/scm/lib/cliparser/Cargo.toml

@@ -14,7 +14,7 @@ anyhow = "1.0.104"
 cpython = { version = "0.7.2", features = ["python3-sys"], optional = true, default-features = false }
 indexmap = { version = "2.14.0", features = ["arbitrary", "rayon", "serde"] }
 serde = { version = "1.0.229", features = ["derive", "rc"] }
-shlex = "1.3"
+shlex = "2.0.1"
 thiserror = "2.0.20"
 
 [features]

eden/scm/lib/cliparser/src/alias.rs

@@ -57,7 +57,7 @@ pub fn expand_aliases<S: ToString>(
         args = if let Some(suffix) = alias.strip_prefix('!') {
             // Alias starting with "!" is "shell alias". It is a string that should
             // be passed "as-is" to the shell (after $1/$2/$@ substitutions).
-            // Round-trip through shlex::split and shlex::quote is not lossless.
+            // Round-trip through shlex::split and shlex::try_quote is not lossless.
             // Therefore use a different alias handling function that does not
             // use shlex::split.
             expand_shell_alias_args(&args, suffix)

eden/scm/lib/clone/Cargo.toml

@@ -27,7 +27,7 @@ sapling-repo = { version = "0.1.0", path = "../repo", features = ["wdir"] }
 sapling-types = { version = "0.1.0", path = "../types" }
 sapling-util = { version = "0.1.0", path = "../util" }
 serde = { version = "1.0.229", features = ["derive", "rc"] }
-shlex = "1.3"
+shlex = "2.0.1"
 thiserror = "2.0.20"
 toml = { version = "1.1.4", features = ["preserve_order"] }
 tracing = { version = "0.1.41", features = ["attributes", "valuable"] }