Replace listkeys("bookmarks") in push path with SLAPI

Summary: Two push-path callers (`_pushdiscoverybookmarks` and `_nowarnheads`) fetch remote bookmarks via the wireproto `listkeys` command. Route them through SLAPI when the repo has it (so Mononoke pushes avoid wireproto `listkeys`), falling back to the push target via `listkeys` for repos without SLAPI (local/eager/ssh) where the call is in-process or non-Mononoke. This mirrors the existing `remotenames._listremotebookmarks` pull-path pattern. `_pushdiscoverybookmarks` needs remote bookmark state to compare against local bookmarks for push discovery, and `_nowarnheads` needs it to decide which heads are bookmarked and should not trigger new-head warnings.

Reviewed By: muirdm

Differential Revision: D104427541

fbshipit-source-id: 63de0889727ae45b405620edcb62658aa60c68bf

Author: lmvasquezg

eden/mononoke/tests/integration/server/test-push-protocol.t

@@ -185,9 +185,6 @@ push to Mononoke
   query 2; still undecided: 4, sample size is: 4
   2 total queries in 0.0000s
   checking for updated bookmarks
-  preparing listkeys for "bookmarks"
-  sending listkeys command
-  received listkey for "bookmarks": 57 bytes
   6 changesets found
   list of changesets:
   73a82cfa87dfc23097b4a429eac744ec99394b30

eden/mononoke/tests/integration/server/test-push-readonly.t

@@ -95,8 +95,5 @@ Check that a push which doesn't move a bookmark is allowed
   local heads: 1; remote heads: 1 (explicit: 0); initial common: 1
   all local heads known remotely
   checking for updated bookmarks
-  preparing listkeys for "bookmarks"
-  sending listkeys command
-  received listkey for "bookmarks": 57 bytes
   no changes found
   [1]

eden/scm/sapling/discovery.py

@@ -166,12 +166,28 @@ def findcommonoutgoing(
     return og
 
 
+def _remotebookmarks(pushop):
+    """Fetch the push target's PullDefaultPublishing bookmarks ({name: hexnode}).
+
+    Matches the legacy `remote.listkeys("bookmarks")`, which returns the
+    PullDefaultPublishing bookmarks for all names (not scoped to local bookmark
+    names). `listbookmarkpatterns(["*"])` with no `kinds` returns the same set
+    (per the pyedenapi binding: empty kinds -> PullDefaultPublishing only). Uses
+    SLAPI when the repo has it (so Mononoke pushes avoid wireproto `listkeys`),
+    falling back to the peer's `listkeys` otherwise (in-process or non-Mononoke).
+    """
+    edenapi = pushop.repo.nullableedenapi
+    if edenapi is not None:
+        fetchedbookmarks = edenapi.listbookmarkpatterns(["*"])
+        return {bm: n for (bm, n) in fetchedbookmarks.items() if n is not None}
+    return pushop.remote.listkeys("bookmarks")
+
+
 def _nowarnheads(pushop):
     # Compute newly pushed bookmarks. We don't warn about bookmarked heads.
     repo = pushop.repo
-    remote = pushop.remote
     localbookmarks = repo._bookmarks
-    remotebookmarks = remote.listkeys("bookmarks")
+    remotebookmarks = _remotebookmarks(pushop)
     bookmarkedheads = set()
 
     # internal config: bookmarks.pushing

eden/scm/sapling/exchange.py

@@ -675,13 +675,12 @@ def _pushdiscoveryphase(pushop):
 def _pushdiscoverybookmarks(pushop):
     ui = pushop.ui
     repo = pushop.repo
-    remote = pushop.remote
     ui.debug("checking for updated bookmarks\n")
     ancestors = ()
     if pushop.revs:
         revnums = list(map(repo.changelog.rev, pushop.revs))
         ancestors = repo.changelog.ancestors(revnums, inclusive=True)
-    remotebookmark = remote.listkeys("bookmarks")
+    remotebookmark = discovery._remotebookmarks(pushop)
 
     explicit = set(
         [repo._bookmarks.expandname(bookmark) for bookmark in pushop.bookmarks]

eden/scm/tests/test-eager-exchange.t

@@ -54,8 +54,7 @@ Push:
   DEBUG eagerepo::api: bookmarks master
   DEBUG eagerepo::api: commit_known 178c10ffbc2f92d5407c14478ae9d9dea81f232e, 99dac869f01e09fe3d501fa645ea524af80d498f
   searching for changes
-  DEBUG eagerepo::api: bookmarks master
-  DEBUG sapling::eagerpeer: listkeyspatterns(bookmarks, ['master']) = sortdict([('master', '178c10ffbc2f92d5407c14478ae9d9dea81f232e')])
+  DEBUG eagerepo::api: list_bookmark_patterns *
   TRACE sapling::eagerpeer: adding   blob 35e7525ce3a48913275d7061dd9a867ffef1e34d
   TRACE sapling::eagerpeer: adding   tree d8dc55ad2b89cdc0f1ee969e5d79bd1eaddb5b43
   TRACE sapling::eagerpeer: adding commit 99dac869f01e09fe3d501fa645ea524af80d498f