Replace '-' -> '_' in Thrift crate names

David Tolnay · meta-codesync[bot] · commit fe865e4af65a · 2026-07-02T13:18:37.000-07:00
Summary: Doing this is simpler than the AI-generated comment explaining why AI didn't want to do this.

Reviewed By: diliop

Differential Revision: D110509600

fbshipit-source-id: 763a3df6142070cd578b701a4e6e6a3b545cab66
diff --git a/eden/fs/service/thrift_streaming/clients/thrift_build.rs b/eden/fs/service/thrift_streaming/clients/thrift_build.rs
@@ -24,8 +24,8 @@ fn main() {
     Config::from_env(GenContext::Clients)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../..")
-        .types_crate("thrift-streaming__types")
-        .clients_crate("thrift-streaming__clients")
+        .types_crate("thrift_streaming__types")
+        .clients_crate("thrift_streaming__clients")
         .options("deprecated_default_enum_min_i32")
         .run(["../../streamingeden.thrift"])
         .expect("Failed while running thrift compilation");
diff --git a/eden/fs/service/thrift_streaming/mocks/thrift_build.rs b/eden/fs/service/thrift_streaming/mocks/thrift_build.rs
@@ -24,8 +24,8 @@ fn main() {
     Config::from_env(GenContext::Mocks)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../..")
-        .types_crate("thrift-streaming__types")
-        .clients_crate("thrift-streaming__clients")
+        .types_crate("thrift_streaming__types")
+        .clients_crate("thrift_streaming__clients")
         .options("deprecated_default_enum_min_i32")
         .run(["../../streamingeden.thrift"])
         .expect("Failed while running thrift compilation");
diff --git a/eden/fs/service/thrift_streaming/services/thrift_build.rs b/eden/fs/service/thrift_streaming/services/thrift_build.rs
@@ -24,8 +24,8 @@ fn main() {
     Config::from_env(GenContext::Services)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../..")
-        .types_crate("thrift-streaming__types")
-        .clients_crate("thrift-streaming__clients")
+        .types_crate("thrift_streaming__types")
+        .clients_crate("thrift_streaming__clients")
         .options("deprecated_default_enum_min_i32")
         .run(["../../streamingeden.thrift"])
         .expect("Failed while running thrift compilation");
diff --git a/eden/fs/service/thrift_streaming/thrift_build.rs b/eden/fs/service/thrift_streaming/thrift_build.rs
@@ -24,8 +24,8 @@ fn main() {
     Config::from_env(GenContext::Types)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../..")
-        .types_crate("thrift-streaming__types")
-        .clients_crate("thrift-streaming__clients")
+        .types_crate("thrift_streaming__types")
+        .clients_crate("thrift_streaming__clients")
         .options("deprecated_default_enum_min_i32")
         .run(["../streamingeden.thrift"])
         .expect("Failed while running thrift compilation");
diff --git a/eden/mononoke/blobstore/if/clients/thrift_build.rs b/eden/mononoke/blobstore/if/clients/thrift_build.rs
@@ -19,8 +19,8 @@ fn main() {
     Config::from_env(GenContext::Clients)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../..")
-        .types_crate("memcache-lock-thrift__types")
-        .clients_crate("memcache-lock-thrift__clients")
+        .types_crate("memcache_lock_thrift__types")
+        .clients_crate("memcache_lock_thrift__clients")
         .run(["../memcache_lock.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/blobstore/if/mocks/thrift_build.rs b/eden/mononoke/blobstore/if/mocks/thrift_build.rs
@@ -19,8 +19,8 @@ fn main() {
     Config::from_env(GenContext::Mocks)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../..")
-        .types_crate("memcache-lock-thrift__types")
-        .clients_crate("memcache-lock-thrift__clients")
+        .types_crate("memcache_lock_thrift__types")
+        .clients_crate("memcache_lock_thrift__clients")
         .run(["../memcache_lock.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/blobstore/if/services/thrift_build.rs b/eden/mononoke/blobstore/if/services/thrift_build.rs
@@ -19,8 +19,8 @@ fn main() {
     Config::from_env(GenContext::Services)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../..")
-        .types_crate("memcache-lock-thrift__types")
-        .clients_crate("memcache-lock-thrift__clients")
+        .types_crate("memcache_lock_thrift__types")
+        .clients_crate("memcache_lock_thrift__clients")
         .run(["../memcache_lock.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/blobstore/if/thrift_build.rs b/eden/mononoke/blobstore/if/thrift_build.rs
@@ -19,8 +19,8 @@ fn main() {
     Config::from_env(GenContext::Types)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../..")
-        .types_crate("memcache-lock-thrift__types")
-        .clients_crate("memcache-lock-thrift__clients")
+        .types_crate("memcache_lock_thrift__types")
+        .clients_crate("memcache_lock_thrift__clients")
         .run(["memcache_lock.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/blobstore/packblob/if/clients/thrift_build.rs b/eden/mononoke/blobstore/packblob/if/clients/thrift_build.rs
@@ -20,8 +20,8 @@ fn main() {
     Config::from_env(GenContext::Clients)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../..")
-        .types_crate("packblob-thrift__types")
-        .clients_crate("packblob-thrift__clients")
+        .types_crate("packblob_thrift__types")
+        .clients_crate("packblob_thrift__clients")
         .run(["../packblob.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/blobstore/packblob/if/mocks/thrift_build.rs b/eden/mononoke/blobstore/packblob/if/mocks/thrift_build.rs
@@ -20,8 +20,8 @@ fn main() {
     Config::from_env(GenContext::Mocks)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../..")
-        .types_crate("packblob-thrift__types")
-        .clients_crate("packblob-thrift__clients")
+        .types_crate("packblob_thrift__types")
+        .clients_crate("packblob_thrift__clients")
         .run(["../packblob.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/blobstore/packblob/if/services/thrift_build.rs b/eden/mononoke/blobstore/packblob/if/services/thrift_build.rs
@@ -20,8 +20,8 @@ fn main() {
     Config::from_env(GenContext::Services)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../..")
-        .types_crate("packblob-thrift__types")
-        .clients_crate("packblob-thrift__clients")
+        .types_crate("packblob_thrift__types")
+        .clients_crate("packblob_thrift__clients")
         .run(["../packblob.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/blobstore/packblob/if/thrift_build.rs b/eden/mononoke/blobstore/packblob/if/thrift_build.rs
@@ -20,8 +20,8 @@ fn main() {
     Config::from_env(GenContext::Types)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../..")
-        .types_crate("packblob-thrift__types")
-        .clients_crate("packblob-thrift__clients")
+        .types_crate("packblob_thrift__types")
+        .clients_crate("packblob_thrift__clients")
         .run(["packblob.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/common/thrift_convert/tests/if/clients/thrift_build.rs b/eden/mononoke/common/thrift_convert/tests/if/clients/thrift_build.rs
@@ -20,8 +20,8 @@ fn main() {
     Config::from_env(GenContext::Clients)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../../..")
-        .types_crate("thrift-convert-test__types")
-        .clients_crate("thrift-convert-test__clients")
+        .types_crate("thrift_convert_test__types")
+        .clients_crate("thrift_convert_test__clients")
         .run(["../thrift_convert_test.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/common/thrift_convert/tests/if/mocks/thrift_build.rs b/eden/mononoke/common/thrift_convert/tests/if/mocks/thrift_build.rs
@@ -20,8 +20,8 @@ fn main() {
     Config::from_env(GenContext::Mocks)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../../..")
-        .types_crate("thrift-convert-test__types")
-        .clients_crate("thrift-convert-test__clients")
+        .types_crate("thrift_convert_test__types")
+        .clients_crate("thrift_convert_test__clients")
         .run(["../thrift_convert_test.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/common/thrift_convert/tests/if/services/thrift_build.rs b/eden/mononoke/common/thrift_convert/tests/if/services/thrift_build.rs
@@ -20,8 +20,8 @@ fn main() {
     Config::from_env(GenContext::Services)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../../..")
-        .types_crate("thrift-convert-test__types")
-        .clients_crate("thrift-convert-test__clients")
+        .types_crate("thrift_convert_test__types")
+        .clients_crate("thrift_convert_test__clients")
         .run(["../thrift_convert_test.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/common/thrift_convert/tests/if/thrift_build.rs b/eden/mononoke/common/thrift_convert/tests/if/thrift_build.rs
@@ -20,8 +20,8 @@ fn main() {
     Config::from_env(GenContext::Types)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../..")
-        .types_crate("thrift-convert-test__types")
-        .clients_crate("thrift-convert-test__clients")
+        .types_crate("thrift_convert_test__types")
+        .clients_crate("thrift_convert_test__clients")
         .run(["thrift_convert_test.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/features/async_requests/if/clients/thrift_build.rs b/eden/mononoke/features/async_requests/if/clients/thrift_build.rs
@@ -50,8 +50,8 @@ fn main() {
     Config::from_env(GenContext::Clients)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../..")
-        .types_crate("async_requests_types-thrift__types")
-        .clients_crate("async_requests_types-thrift__clients")
+        .types_crate("async_requests_types_thrift__types")
+        .clients_crate("async_requests_types_thrift__clients")
         .run(["../async_requests_types_thrift.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/features/async_requests/if/mocks/thrift_build.rs b/eden/mononoke/features/async_requests/if/mocks/thrift_build.rs
@@ -50,8 +50,8 @@ fn main() {
     Config::from_env(GenContext::Mocks)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../..")
-        .types_crate("async_requests_types-thrift__types")
-        .clients_crate("async_requests_types-thrift__clients")
+        .types_crate("async_requests_types_thrift__types")
+        .clients_crate("async_requests_types_thrift__clients")
         .run(["../async_requests_types_thrift.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/features/async_requests/if/services/thrift_build.rs b/eden/mononoke/features/async_requests/if/services/thrift_build.rs
@@ -50,8 +50,8 @@ fn main() {
     Config::from_env(GenContext::Services)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../..")
-        .types_crate("async_requests_types-thrift__types")
-        .clients_crate("async_requests_types-thrift__clients")
+        .types_crate("async_requests_types_thrift__types")
+        .clients_crate("async_requests_types_thrift__clients")
         .run(["../async_requests_types_thrift.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/features/async_requests/if/thrift_build.rs b/eden/mononoke/features/async_requests/if/thrift_build.rs
@@ -50,8 +50,8 @@ fn main() {
     Config::from_env(GenContext::Types)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../..")
-        .types_crate("async_requests_types-thrift__types")
-        .clients_crate("async_requests_types-thrift__clients")
+        .types_crate("async_requests_types_thrift__types")
+        .clients_crate("async_requests_types_thrift__clients")
         .run(["async_requests_types_thrift.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/features/microwave/if/clients/thrift_build.rs b/eden/mononoke/features/microwave/if/clients/thrift_build.rs
@@ -45,8 +45,8 @@ fn main() {
     Config::from_env(GenContext::Clients)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../..")
-        .types_crate("microwave-if__types")
-        .clients_crate("microwave-if__clients")
+        .types_crate("microwave_if__types")
+        .clients_crate("microwave_if__clients")
         .run(["../microwave.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/features/microwave/if/mocks/thrift_build.rs b/eden/mononoke/features/microwave/if/mocks/thrift_build.rs
@@ -45,8 +45,8 @@ fn main() {
     Config::from_env(GenContext::Mocks)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../..")
-        .types_crate("microwave-if__types")
-        .clients_crate("microwave-if__clients")
+        .types_crate("microwave_if__types")
+        .clients_crate("microwave_if__clients")
         .run(["../microwave.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/features/microwave/if/services/thrift_build.rs b/eden/mononoke/features/microwave/if/services/thrift_build.rs
@@ -45,8 +45,8 @@ fn main() {
     Config::from_env(GenContext::Services)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../..")
-        .types_crate("microwave-if__types")
-        .clients_crate("microwave-if__clients")
+        .types_crate("microwave_if__types")
+        .clients_crate("microwave_if__clients")
         .run(["../microwave.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/features/microwave/if/thrift_build.rs b/eden/mononoke/features/microwave/if/thrift_build.rs
@@ -45,8 +45,8 @@ fn main() {
     Config::from_env(GenContext::Types)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../..")
-        .types_crate("microwave-if__types")
-        .clients_crate("microwave-if__clients")
+        .types_crate("microwave_if__types")
+        .clients_crate("microwave_if__clients")
         .run(["microwave.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/git/git_types/if/clients/thrift_build.rs b/eden/mononoke/git/git_types/if/clients/thrift_build.rs
@@ -44,8 +44,8 @@ fn main() {
     Config::from_env(GenContext::Clients)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../..")
-        .types_crate("git-types-thrift__types")
-        .clients_crate("git-types-thrift__clients")
+        .types_crate("git_types_thrift__types")
+        .clients_crate("git_types_thrift__clients")
         .options("default_enum_zero")
         .run(["../git_types_thrift.thrift"])
         .expect("Failed while running thrift compilation");
diff --git a/eden/mononoke/git/git_types/if/mocks/thrift_build.rs b/eden/mononoke/git/git_types/if/mocks/thrift_build.rs
@@ -44,8 +44,8 @@ fn main() {
     Config::from_env(GenContext::Mocks)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../..")
-        .types_crate("git-types-thrift__types")
-        .clients_crate("git-types-thrift__clients")
+        .types_crate("git_types_thrift__types")
+        .clients_crate("git_types_thrift__clients")
         .options("default_enum_zero")
         .run(["../git_types_thrift.thrift"])
         .expect("Failed while running thrift compilation");
diff --git a/eden/mononoke/git/git_types/if/services/thrift_build.rs b/eden/mononoke/git/git_types/if/services/thrift_build.rs
@@ -44,8 +44,8 @@ fn main() {
     Config::from_env(GenContext::Services)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../..")
-        .types_crate("git-types-thrift__types")
-        .clients_crate("git-types-thrift__clients")
+        .types_crate("git_types_thrift__types")
+        .clients_crate("git_types_thrift__clients")
         .options("default_enum_zero")
         .run(["../git_types_thrift.thrift"])
         .expect("Failed while running thrift compilation");
diff --git a/eden/mononoke/git/git_types/if/thrift_build.rs b/eden/mononoke/git/git_types/if/thrift_build.rs
@@ -44,8 +44,8 @@ fn main() {
     Config::from_env(GenContext::Types)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../..")
-        .types_crate("git-types-thrift__types")
-        .clients_crate("git-types-thrift__clients")
+        .types_crate("git_types_thrift__types")
+        .clients_crate("git_types_thrift__clients")
         .options("default_enum_zero")
         .run(["git_types_thrift.thrift"])
         .expect("Failed while running thrift compilation");
diff --git a/eden/mononoke/mercurial/types/if/clients/thrift_build.rs b/eden/mononoke/mercurial/types/if/clients/thrift_build.rs
@@ -44,8 +44,8 @@ fn main() {
     Config::from_env(GenContext::Clients)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../..")
-        .types_crate("mercurial-thrift__types")
-        .clients_crate("mercurial-thrift__clients")
+        .types_crate("mercurial_thrift__types")
+        .clients_crate("mercurial_thrift__clients")
         .run(["../mercurial_thrift.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/mercurial/types/if/mocks/thrift_build.rs b/eden/mononoke/mercurial/types/if/mocks/thrift_build.rs
@@ -44,8 +44,8 @@ fn main() {
     Config::from_env(GenContext::Mocks)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../..")
-        .types_crate("mercurial-thrift__types")
-        .clients_crate("mercurial-thrift__clients")
+        .types_crate("mercurial_thrift__types")
+        .clients_crate("mercurial_thrift__clients")
         .run(["../mercurial_thrift.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/mercurial/types/if/services/thrift_build.rs b/eden/mononoke/mercurial/types/if/services/thrift_build.rs
@@ -44,8 +44,8 @@ fn main() {
     Config::from_env(GenContext::Services)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../..")
-        .types_crate("mercurial-thrift__types")
-        .clients_crate("mercurial-thrift__clients")
+        .types_crate("mercurial_thrift__types")
+        .clients_crate("mercurial_thrift__clients")
         .run(["../mercurial_thrift.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/mercurial/types/if/thrift_build.rs b/eden/mononoke/mercurial/types/if/thrift_build.rs
@@ -44,8 +44,8 @@ fn main() {
     Config::from_env(GenContext::Types)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../..")
-        .types_crate("mercurial-thrift__types")
-        .clients_crate("mercurial-thrift__clients")
+        .types_crate("mercurial_thrift__types")
+        .clients_crate("mercurial_thrift__clients")
         .run(["mercurial_thrift.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/repo_attributes/filenodes/if/clients/thrift_build.rs b/eden/mononoke/repo_attributes/filenodes/if/clients/thrift_build.rs
@@ -45,8 +45,8 @@ fn main() {
     Config::from_env(GenContext::Clients)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../..")
-        .types_crate("filenodes-if__types")
-        .clients_crate("filenodes-if__clients")
+        .types_crate("filenodes_if__types")
+        .clients_crate("filenodes_if__clients")
         .run(["../filenodes.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/repo_attributes/filenodes/if/mocks/thrift_build.rs b/eden/mononoke/repo_attributes/filenodes/if/mocks/thrift_build.rs
@@ -45,8 +45,8 @@ fn main() {
     Config::from_env(GenContext::Mocks)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../..")
-        .types_crate("filenodes-if__types")
-        .clients_crate("filenodes-if__clients")
+        .types_crate("filenodes_if__types")
+        .clients_crate("filenodes_if__clients")
         .run(["../filenodes.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/repo_attributes/filenodes/if/services/thrift_build.rs b/eden/mononoke/repo_attributes/filenodes/if/services/thrift_build.rs
@@ -45,8 +45,8 @@ fn main() {
     Config::from_env(GenContext::Services)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../../..")
-        .types_crate("filenodes-if__types")
-        .clients_crate("filenodes-if__clients")
+        .types_crate("filenodes_if__types")
+        .clients_crate("filenodes_if__clients")
         .run(["../filenodes.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/repo_attributes/filenodes/if/thrift_build.rs b/eden/mononoke/repo_attributes/filenodes/if/thrift_build.rs
@@ -45,8 +45,8 @@ fn main() {
     Config::from_env(GenContext::Types)
         .expect("Failed to instantiate thrift_compiler::Config")
         .base_path("../../../../..")
-        .types_crate("filenodes-if__types")
-        .clients_crate("filenodes-if__clients")
+        .types_crate("filenodes_if__types")
+        .clients_crate("filenodes_if__clients")
         .run(["filenodes.thrift"])
         .expect("Failed while running thrift compilation");
 }
diff --git a/eden/mononoke/repo_attributes/mutable_renames/if/clients/thrift_build.rs b/eden/mononoke/repo_attributes/mutable_renames/if/clients/thrift_build.rs
diff --git a/eden/mononoke/repo_attributes/mutable_renames/if/mocks/thrift_build.rs b/eden/mononoke/repo_attributes/mutable_renames/if/mocks/thrift_build.rs
diff --git a/eden/mononoke/repo_attributes/mutable_renames/if/services/thrift_build.rs b/eden/mononoke/repo_attributes/mutable_renames/if/services/thrift_build.rs
diff --git a/eden/mononoke/repo_attributes/mutable_renames/if/thrift_build.rs b/eden/mononoke/repo_attributes/mutable_renames/if/thrift_build.rs
