Skip to content

Make graph/message separator width configurable in renderdag #1328

@dpc

Description

@dpc

renderdag appears to hardcode one separator space between the rendered graph and the message text, e.g. @ message: one space from the graph cell, plus one separator before the message.

The hardcoded separator seems to be here:

https://github.com/facebook/sapling/blob/main/eden/scm/lib/renderdag/src/output.rs#L45-L54

and for pad/message continuation lines:

https://github.com/facebook/sapling/blob/main/eden/scm/lib/renderdag/src/output.rs#L58-L70

In Jujutsu (jj), this can feel like wasted horizontal space in jj log, where users may prefer @ message instead.

It would be useful if renderdag exposed an option for the graph/message separator width/content, defaulting to the current behavior, so callers could choose 0/"" or something for more compact/different output.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions