When a GitHub squash commit title contains both an issue reference and the appended pull-request number, Sapling selects the issue number as the pull request.
Example commit:
omry/omegaconf@93023e7
Its title is:
Preserve ValueNode types in OmegaConf.masked_copy (#813) (#1308)
#813 is an issue. The actual pull request is #1308:
omry/omegaconf#1308
Running:
$ sl pull
pulling from ssh://git@github.com/omry/omegaconf.git
warning: failed to read from Github for landed commits (RuntimeError('{
"data": {
"repository": {
"pullRequest": null
}
},
"errors": [
{
"type": "NOT_FOUND",
"path": ["repository", "pullRequest"],
"message": "Could not resolve to a PullRequest with the number of 813."
}
]
}')), not marking commits as landed
The pull succeeds, but Sapling does not mark the corresponding local commits as landed.
Expected behavior:
sl pull should identify #1308 as the associated pull request and correctly mark the corresponding commits as landed.
Environment:
Sapling 0.2.20260317-201835+0234c21f
Related reports with the same top-level warning but different causes:
When a GitHub squash commit title contains both an issue reference and the appended pull-request number, Sapling selects the issue number as the pull request.
Example commit:
omry/omegaconf@93023e7
Its title is:
#813is an issue. The actual pull request is#1308:omry/omegaconf#1308
Running:
The pull succeeds, but Sapling does not mark the corresponding local commits as landed.
Expected behavior:
sl pullshould identify#1308as the associated pull request and correctly mark the corresponding commits as landed.Environment:
Related reports with the same top-level warning but different causes:
make_requestwas never awaited duringsl pr pull#583