Skip to content

Commit 8cf9b23

Browse files
David Tolnayfacebook-github-bot
David Tolnay
authored andcommitted
Resolve needless_continue clippy lint
Summary: ```lang=text warning: this `continue` expression is redundant --> fbcode/buck2/app/buck2_client/src/commands/log/diff/action_divergence.rs:84:21 | 84 | continue; | ^^^^^^^^ | = help: consider dropping the `continue` expression = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_continue = note: requested on the command line with `-W clippy::needless-continue` warning: this `continue` expression is redundant --> fbcode/buck2/app/buck2_client_ctx/src/stdin.rs:129:21 | 129 | continue; | ^^^^^^^^ | = help: consider dropping the `continue` expression = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_continue = note: requested on the command line with `-W clippy::needless-continue` warning: this `continue` expression is redundant --> fbcode/buck2/app/buck2_client_ctx/src/stdin.rs:137:17 | 137 | continue; | ^^^^^^^^ | = help: consider dropping the `continue` expression = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_continue warning: this `continue` expression is redundant --> fbcode/buck2/app/buck2_error/src/starlark_error.rs:106:17 | 106 | continue; | ^^^^^^^^ | = help: consider dropping the `continue` expression = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_continue = note: requested on the command line with `-W clippy::needless-continue` warning: this `continue` expression is redundant --> fbcode/buck2/app/buck2_events/src/span.rs:53:25 | 53 | None => continue, | ^^^^^^^^ | = help: consider dropping the `continue` expression = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_continue = note: requested on the command line with `-W clippy::needless-continue` warning: this `continue` expression is redundant --> fbcode/buck2/app/buck2_interpreter_for_build/src/interpreter/module_internals.rs:209:25 | 209 | continue; | ^^^^^^^^ | = help: consider dropping the `continue` expression = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_continue = note: requested on the command line with `-W clippy::needless-continue` warning: this `continue` expression is redundant --> fbcode/buck2/app/buck2_server/src/daemon/server.rs:1601:33 | 1601 | ... continue; | ^^^^^^^^ | = help: consider dropping the `continue` expression = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_continue = note: requested on the command line with `-W clippy::needless-continue` warning: this `continue` expression is redundant --> fbcode/buck2/app/buck2_server/src/daemon/server.rs:1609:25 | 1609 | continue; | ^^^^^^^^ | = help: consider dropping the `continue` expression = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_continue warning: this `continue` expression is redundant --> fbcode/buck2/dice/dice/src/impls/task/state.rs:62:25 | 62 | continue; | ^^^^^^^^ | = help: consider dropping the `continue` expression = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_continue = note: requested on the command line with `-W clippy::needless-continue` warning: this `continue` expression is redundant --> fbcode/buck2/facebook/buck2tail/src/main.rs:70:17 | 70 | continue; | ^^^^^^^^ | = help: consider dropping the `continue` expression = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_continue = note: requested on the command line with `-W clippy::needless-continue` warning: this `continue` expression is redundant --> fbcode/buck2/facebook/buck2tail/src/main.rs:74:17 | 74 | continue; | ^^^^^^^^ | = help: consider dropping the `continue` expression = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_continue warning: this `continue` expression is redundant --> fbcode/buck2/starlark-rust/starlark/src/debug/adapter/implementation.rs:159:47 | 159 | Ok(Next::RemainPaused) => continue, | ^^^^^^^^ | = help: consider dropping the `continue` expression = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_continue = note: requested on the command line with `-W clippy::needless-continue` warning: this `continue` expression is redundant --> fbcode/buck2/starlark-rust/starlark_bin/bin/bazel.rs:555:21 | 555 | continue; | ^^^^^^^^ | = help: consider dropping the `continue` expression = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_continue = note: requested on the command line with `-W clippy::needless-continue` warning: this `continue` expression is redundant --> fbcode/buck2/superconsole/src/output.rs:242:13 | 242 | continue; | ^^^^^^^^ | = help: consider dropping the `continue` expression = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_continue = note: requested on the command line with `-W clippy::needless-continue` errors: 0; warnings: 14 ``` Reviewed By: diliop Differential Revision: D72737414 fbshipit-source-id: 74fb89895a83bd306a81b28fa9e3499c416d180d
1 parent 476ce54 commit 8cf9b23

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

starlark/src/debug/adapter/implementation.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ impl<'a, 'e: 'a> BeforeStmtFuncDyn<'a, 'e> for DapAdapterEvalHookImpl {
156156
self.step = Some((kind, eval.call_stack_count()));
157157
break;
158158
}
159-
Ok(Next::RemainPaused) => continue,
159+
Ok(Next::RemainPaused) => {}
160160
Err(..) => {
161161
// DapAdapter has been dropped so we'll continue.
162162
break;

starlark_bin/bin/bazel.rs

-1
Original file line numberDiff line numberDiff line change
@@ -552,7 +552,6 @@ impl BazelContext {
552552
}));
553553
}
554554
}
555-
continue;
556555
} else if options.files != FilesystemFileCompletionOptions::None {
557556
// Check if it's in the list of allowed extensions. If we have a list, and it
558557
// doesn't contain the extension, or the file has no extension, skip this file.

0 commit comments

Comments
 (0)