fix: eslint allow using vars as key in dynamic styles #393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
Fixed the following cases casuing "Computed key cannot be resolved.eslint(@stylexjs/valid-styles)" lint error.
Linked PR/Issues
Fixes #337
Additional Context
For dynamic styles (not
style.value.type === 'ObjectExpression'
) we are missing the check for stylex defined variables for object keys, resulting in the "cannot be resolved" error, the fix was to add an early check for the style key being a defined variable and returning early.TBH I don't quite understand why the first case was broken as reported in #337, how is that not an object expression? But anyways the fix seem to fix it.
Pre-flight checklist
Contribution Guidelines