Skip to content

Commit 2084064

Browse files
vilattofacebook-github-bot
authored andcommitted
Define a new thrift endpoint for unmount with extra options
Summary: ## This Diff Defined a new endpoint "unmountV2" which accepts UnmountArgument. ## Context Extend eden rm with a "--no-force" flag so "--force" is not used when unmounting a mount point. Reviewed By: genevievehelsel Differential Revision: D69407041 fbshipit-source-id: f832db8504acf7f2b331afdb0f9dfb34c3ac9191
1 parent 0006295 commit 2084064

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

eden/fs/service/eden.thrift

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,11 @@ struct MountArgument {
252252
3: bool readOnly;
253253
}
254254

255+
struct UnmountArgument {
256+
1: MountId mountId;
257+
2: bool useForce = true;
258+
}
259+
255260
union SHA1Result {
256261
1: BinaryHash sha1;
257262
2: EdenError error;
@@ -2020,6 +2025,7 @@ service EdenService extends fb303_core.BaseService {
20202025
list<MountInfo> listMounts() throws (1: EdenError ex);
20212026
void mount(1: MountArgument info) throws (1: EdenError ex);
20222027
void unmount(1: PathString mountPoint) throws (1: EdenError ex);
2028+
void unmountV2(1: UnmountArgument unmountArgument) throws (1: EdenError ex);
20232029

20242030
/**
20252031
* Potentially check out the specified snapshot, reporting conflicts (and

0 commit comments

Comments
 (0)