getdeps generate-github-actions: remove --recursive from build cmd

Summary:
The `build` subcommand already builds all transitive deps unconditionally (`manifests_in_dependency_order()` always returns the full dep graph). The `--recursive` flag added to `final_build_cmd` in D106028158 is not a recognized argument for `build`, so argparse exits non-zero and every GHA job fails before building anything.

Fix: remove `--recursive` from the generated build step in `workflow_generator.py`. Regenerated all affected workflow files via `update-all-github-actions.sh` and updated test fixtures with `UPDATE_FIXTURES=1 buck run`.

The `--recursive` flag remains correct on `install-system-deps` and `query-paths` steps, where it is a defined and meaningful argument.

Supersedes D106119149.

Reviewed By: bigfootjon

Differential Revision: D106122539

fbshipit-source-id: f10dc25bee75b64171844d94cd35eec0f37e8445

Author: r-barnes

.github/workflows/getdeps_linux.yml

@@ -167,7 +167,7 @@ jobs:
       run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests edencommon
 
     - name: Build watchman
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --build-type RelWithDebInfo --recursive --src-dir=. watchman --project-install-prefix watchman:/usr/local
+      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --build-type RelWithDebInfo --src-dir=. watchman --project-install-prefix watchman:/usr/local
 
     - name: Show sccache stats
       if: always()

.github/workflows/getdeps_mac.yml

@@ -162,7 +162,7 @@ jobs:
       run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests edencommon
 
     - name: Build watchman
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --build-type RelWithDebInfo --recursive --src-dir=. watchman --project-install-prefix watchman:/usr/local
+      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --build-type RelWithDebInfo --src-dir=. watchman --project-install-prefix watchman:/usr/local
 
     - name: Show sccache stats
       if: always()

.github/workflows/getdeps_windows.yml

@@ -153,7 +153,7 @@ jobs:
       run: python build/fbcode_builder/getdeps.py fetch --no-tests edencommon
 
     - name: Build watchman
-      run: python build/fbcode_builder/getdeps.py build --build-type RelWithDebInfo --recursive --src-dir=. watchman
+      run: python build/fbcode_builder/getdeps.py build --build-type RelWithDebInfo --src-dir=. watchman
 
     - name: Show sccache stats
       if: always()

build/fbcode_builder/getdeps/test/fixtures/expected/folly_shared_libs/getdeps_shared-libs_linux.yml

@@ -125,7 +125,7 @@ jobs:
       run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests xz
 
     - name: Build folly
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --build-type RelWithDebInfo --shared-lib --recursive --src-dir=. folly --project-install-prefix folly:/usr/local
+      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --build-type RelWithDebInfo --shared-lib --src-dir=. folly --project-install-prefix folly:/usr/local
 
     - name: Show sccache stats
       if: always()

build/fbcode_builder/getdeps/test/fixtures/expected/openr/getdeps_linux.yml

@@ -140,7 +140,7 @@ jobs:
       run: python3 build/fbcode_builder/getdeps.py fetch --no-tests fb303
 
     - name: Build openr
-      run: python3 build/fbcode_builder/getdeps.py build --build-type RelWithDebInfo --recursive --src-dir=. openr --project-install-prefix openr:/usr/local
+      run: python3 build/fbcode_builder/getdeps.py build --build-type RelWithDebInfo --src-dir=. openr --project-install-prefix openr:/usr/local
 
     - name: Show sccache stats
       if: always()

build/fbcode_builder/getdeps/test/fixtures/expected/rebalancer_linux/getdeps_linux.yml

@@ -145,7 +145,7 @@ jobs:
         df -h
 
     - name: Build rebalancer
-      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --build-type RelWithDebInfo --recursive --src-dir=. rebalancer --project-install-prefix rebalancer:/usr/local --extra-cmake-defines '{"CMAKE_POSITION_INDEPENDENT_CODE":"ON"}'
+      run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --build-type RelWithDebInfo --src-dir=. rebalancer --project-install-prefix rebalancer:/usr/local --extra-cmake-defines '{"CMAKE_POSITION_INDEPENDENT_CODE":"ON"}'
 
     - name: Show sccache stats
       if: always()

build/fbcode_builder/getdeps/test/fixtures/expected/xxhash_plain/getdeps_linux.yml

@@ -40,7 +40,7 @@ jobs:
       run: python3 build/fbcode_builder/getdeps.py query-paths --recursive --src-dir=. xxhash  >> "$GITHUB_OUTPUT"
 
     - name: Build xxhash
-      run: python3 build/fbcode_builder/getdeps.py build --build-type RelWithDebInfo --recursive --src-dir=. xxhash --project-install-prefix xxhash:/usr/local
+      run: python3 build/fbcode_builder/getdeps.py build --build-type RelWithDebInfo --src-dir=. xxhash --project-install-prefix xxhash:/usr/local
 
     - name: Show sccache stats
       if: always()

build/fbcode_builder/getdeps/test/fixtures/expected/xxhash_plain/getdeps_mac.yml

@@ -46,7 +46,7 @@ jobs:
       run: python3 build/fbcode_builder/getdeps.py query-paths --recursive --src-dir=. xxhash  >> "$GITHUB_OUTPUT"
 
     - name: Build xxhash
-      run: python3 build/fbcode_builder/getdeps.py build --build-type RelWithDebInfo --recursive --src-dir=. xxhash --project-install-prefix xxhash:/usr/local
+      run: python3 build/fbcode_builder/getdeps.py build --build-type RelWithDebInfo --src-dir=. xxhash --project-install-prefix xxhash:/usr/local
 
     - name: Show sccache stats
       if: always()

build/fbcode_builder/getdeps/test/fixtures/expected/xxhash_plain/getdeps_windows.yml

@@ -53,7 +53,7 @@ jobs:
       shell: pwsh
 
     - name: Build xxhash
-      run: python build/fbcode_builder/getdeps.py build --build-type RelWithDebInfo --recursive --src-dir=. xxhash
+      run: python build/fbcode_builder/getdeps.py build --build-type RelWithDebInfo --src-dir=. xxhash
 
     - name: Show sccache stats
       if: always()

build/fbcode_builder/getdeps/workflow_generator.py

@@ -280,7 +280,7 @@ def cmake_arg_for(name):
         # round-trips are net-negative at typical sccache hit rates.
         final_build_cmd = (
             f"{getdepscmd}{allow_sys_arg} build {build_type_arg}{tests_arg}"
-            f"--recursive --src-dir=. {manifest.name}{project_prefix}"
+            f"--src-dir=. {manifest.name}{project_prefix}"
             f"{cmake_arg_for(manifest.name)}"
         )