Skip to content

Commit 8344ccb

Browse files
Satish Kumarmeta-codesync[bot]
authored andcommitted
Remove proxygen dependency from fbthrift-python build
Summary: Remove proxygen as a build dependency for fbthrift-python: - Delete proxygen-python manifest (no longer needed) - Remove proxygen-python from fbthrift-python deps - Remove find_package(proxygen) from CMakeLists.txt - Skip http2_helper files in symlink_dir_contents (depend on proxygen) - Remove proxygen include dirs from Cython include path - Add --enable-shared guard to prevent --disable-shared injection on manifests with explicit --enable-shared Validated in createdbysk/fbthrift fork: TDD RED/GREEN (347/347 tests pass), CI GREEN. Reviewed By: vitaut Differential Revision: D95712264 fbshipit-source-id: 93c634ff2d011366613ace9f062a6bb9de66c493
1 parent acb55fb commit 8344ccb

File tree

2 files changed

+5
-46
lines changed

2 files changed

+5
-46
lines changed

build/fbcode_builder/getdeps/builder.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,11 @@ def __init__(
481481
inst_dir,
482482
)
483483
self.args: list[str] = args or []
484-
if not build_opts.shared_libs and "--disable-shared" not in self.args:
484+
if (
485+
not build_opts.shared_libs
486+
and "--disable-shared" not in self.args
487+
and "--enable-shared" not in self.args
488+
):
485489
self.args.append("--disable-shared")
486490
self.conf_env_args: dict[str, list[str]] = conf_env_args or {}
487491

build/fbcode_builder/manifests/proxygen-python

Lines changed: 0 additions & 45 deletions
This file was deleted.

0 commit comments

Comments
 (0)