Allow passing a timeout to unit tests

Summary:
**Pre-submission checklist**
- [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install`
- [x] `pre-commit run`

When running unit tests, no timeout was enforced. Add an optional
`--timeout` flag to `getdeps.py` that is passed to `ctest` and update
our build script to set a default timeout of 90 seconds per test, which
is generous enough for now.

X-link: facebook/fboss#654

Reviewed By: ahornby

Differential Revision: D86883098

Pulled By: KevinYakar

fbshipit-source-id: 9c841311460a546ae9189ddf62ee461aad948871

Author: benoit-nexthop

build/fbcode_builder/getdeps.py

@@ -940,6 +940,7 @@ def run_project_cmd(self, args, loader, manifest):
             test_filter=args.filter,
             retry=args.retry,
             no_testpilot=args.no_testpilot,
+            timeout=args.timeout,
         )
 
     def setup_project_cmd_parser(self, parser):
@@ -957,6 +958,12 @@ def setup_project_cmd_parser(self, parser):
             help="Do not use Test Pilot even when available",
             action="store_true",
         )
+        parser.add_argument(
+            "--timeout",
+            type=int,
+            default=None,
+            help="Timeout in seconds for each individual test",
+        )
 
 
 @cmd(

build/fbcode_builder/getdeps/builder.py

@@ -238,7 +238,9 @@ def num_jobs(self) -> int:
             )
         )
 
-    def run_tests(self, schedule_type, owner, test_filter, retry, no_testpilot) -> None:
+    def run_tests(
+        self, schedule_type, owner, test_filter, retry, no_testpilot, timeout=None
+    ) -> None:
         """Execute any tests that we know how to run.  If they fail,
         raise an exception."""
         pass
@@ -343,7 +345,9 @@ def _build(self, reconfigure) -> None:
             for file in glob.glob(srcpattern):
                 shutil.copy(file, libdir)
 
-    def run_tests(self, schedule_type, owner, test_filter, retry, no_testpilot) -> None:
+    def run_tests(
+        self, schedule_type, owner, test_filter, retry, no_testpilot, timeout=None
+    ) -> None:
         if not self.test_args:
             return
 
@@ -358,6 +362,9 @@ def run_tests(self, schedule_type, owner, test_filter, retry, no_testpilot) -> N
         else:
             env["GETDEPS_TEST_RETRY"] = 0
 
+        if timeout is not None:
+            env["GETDEPS_TEST_TIMEOUT"] = str(timeout)
+
         cmd = (
             [self._make_binary, "-j%s" % self.num_jobs]
             + self.test_args
@@ -919,7 +926,7 @@ def _build(self, reconfigure: bool) -> None:
         )
 
     def run_tests(
-        self, schedule_type, owner, test_filter, retry: int, no_testpilot
+        self, schedule_type, owner, test_filter, retry: int, no_testpilot, timeout=None
     ) -> None:
         env = self._compute_env()
         ctest = path_search(env, "ctest")
@@ -1066,6 +1073,9 @@ def list_tests():
                 if run_id is not None:
                     testpilot_args += ["--run-id", run_id]
 
+                if timeout is not None:
+                    testpilot_args += ["--timeout", str(timeout)]
+
                 if test_filter:
                     testpilot_args += ["--", test_filter]
 
@@ -1126,6 +1136,8 @@ def list_tests():
             ]
             if test_filter:
                 args += ["-R", test_filter]
+            if timeout is not None:
+                args += ["--timeout", str(timeout)]
 
             count = 0
             retcode = -1
@@ -1421,7 +1433,9 @@ def _build(self, reconfigure) -> None:
         with open(os.path.join(self.inst_dir, ".built-by-getdeps"), "w") as f:
             f.write("built")
 
-    def run_tests(self, schedule_type, owner, test_filter, retry, no_testpilot) -> None:
+    def run_tests(
+        self, schedule_type, owner, test_filter, retry, no_testpilot, timeout=None
+    ) -> None:
         # setup.py actually no longer has a standard command for running tests.
         # Instead we let manifest files specify an arbitrary Python file to run
         # as a test.

build/fbcode_builder/getdeps/cargo.py

@@ -203,7 +203,9 @@ def _build(self, reconfigure) -> None:
             build_source_dir, os.path.join(self.inst_dir, "source")
         )
 
-    def run_tests(self, schedule_type, owner, test_filter, retry, no_testpilot) -> None:
+    def run_tests(
+        self, schedule_type, owner, test_filter, retry, no_testpilot, timeout=None
+    ) -> None:
         if test_filter:
             args = ["--", test_filter]
         else: