Skip to content

OSS build broken: eden.thrift includes non-exported eden/fs/utils/GlobPath.h #1355

Description

@daeho-ro

CI on main has been red since 542ccb7 (linux, mac, package):

eden_types.h:15:10: fatal error: eden/fs/utils/GlobPath.h: No such file or directory

That commit added cpp_include "eden/fs/utils/GlobPath.h" to eden/fs/service/eden.thrift, but this repo only mirrors eden/**/*.thrift, and the header is not exported anywhere.

Mirroring that one header should be enough: it is header-only, and its only eden dependency is eden/common/utils/PathFuncs.h, whose new storage_type/intoStorage API did ship in edencommon v2026.08.03.00 — I verified GlobPath.h compiles cleanly against it (and fails against v2026.07.27.00).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions