Skip to content

Commit 0ea34b7

Browse files
J8118meta-codesync[bot]
authored andcommitted
Fix import casing mismatch for gentest types.ts (#1929)
Summary: The file `gentest/src/types.ts` is recorded in git with a lowercase `t`, but all 7 imports across the gentest source reference `Types.ts` (uppercase `T`). This casing mismatch was introduced in #1889 (`dcaa7ca7`) when the gentest was rewritten — the file was created as `types.ts` but the imports were written as `Types.ts` in the same commit. This causes TypeScript error TS1261 on case-insensitive filesystems (Windows/macOS) where the filesystem resolves both casings to the same file but TypeScript flags the inconsistency. On case-sensitive filesystems (Linux), the mismatched casing could cause module resolution issues depending on the TypeScript configuration. **Files changed (7 import corrections):** - `gentest/src/cli.ts` - `gentest/src/CssToYoga.ts` - `gentest/src/buildLayoutTree.ts` - `gentest/src/emitters/Emitter.ts` - `gentest/src/emitters/CppEmitter.ts` - `gentest/src/emitters/JavascriptEmitter.ts` - `gentest/src/emitters/JavaEmitter.ts` Pull Request resolved: #1929 Test Plan: - `yarn workspace gentest run tsc` now passes cleanly (previously failed with TS1261) - Import-only change — no logic modifications Reviewed By: NickGerleman Differential Revision: D100144393 Pulled By: fabriziocucci fbshipit-source-id: 273124bb478a6c6441b60ac8b086236440e0a90a
1 parent d382d33 commit 0ea34b7

7 files changed

Lines changed: 7 additions & 7 deletions

File tree

gentest/src/CssToYoga.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*/
99

1010
import type Emitter from './emitters/Emitter.ts';
11-
import type {ParsedStyles, ValueWithUnit} from './Types.ts';
11+
import type {ParsedStyles, ValueWithUnit} from './types.ts';
1212

1313
const INVISIBLE_BORDER_STYLES = new Set(['none', 'initial']);
1414

gentest/src/buildLayoutTree.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*/
99

1010
import type {WebDriver} from 'selenium-webdriver';
11-
import type {LayoutNode} from './Types.ts';
11+
import type {LayoutNode} from './types.ts';
1212

1313
/**
1414
* Build the layout tree by querying the DOM via a single executeScript call.

gentest/src/cli.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import readline from 'node:readline/promises';
1818
import signedsource from 'signedsource';
1919
import {glob} from 'glob';
2020

21-
import type {LayoutNode} from './Types.ts';
21+
import type {LayoutNode} from './types.ts';
2222
import {createChromePool} from './ChromePool.ts';
2323
import buildLayoutTree from './buildLayoutTree.ts';
2424
import {CppEmitter} from './emitters/CppEmitter.ts';

gentest/src/emitters/CppEmitter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*/
99

1010
import Emitter from './Emitter.ts';
11-
import type {ValueWithUnit} from '../Types.ts';
11+
import type {ValueWithUnit} from '../types.ts';
1212

1313
function toValueCpp(value: string | number): string {
1414
const n = value.toString().replace('px', '').replace('%', '');

gentest/src/emitters/Emitter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @format
88
*/
99

10-
import type {ValueWithUnit, LayoutNode} from '../Types.ts';
10+
import type {ValueWithUnit, LayoutNode} from '../types.ts';
1111
import {
1212
parseStyleAttribute,
1313
applyStyles,

gentest/src/emitters/JavaEmitter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*/
99

1010
import Emitter from './Emitter.ts';
11-
import type {ValueWithUnit} from '../Types.ts';
11+
import type {ValueWithUnit} from '../types.ts';
1212

1313
function toValueJava(value: string | number): string {
1414
const n = value.toString().replace('px', '').replace('%', '');

gentest/src/emitters/JavascriptEmitter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*/
99

1010
import Emitter from './Emitter.ts';
11-
import type {ValueWithUnit} from '../Types.ts';
11+
import type {ValueWithUnit} from '../types.ts';
1212

1313
function toValueJavascript(value: ValueWithUnit): string {
1414
switch (value.type) {

0 commit comments

Comments
 (0)