Skip to content

Commit 28573da

Browse files
add comments from spec
1 parent 59115b2 commit 28573da

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

yoga/algorithm/AbsoluteLayout.cpp

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ static inline void setFlexStartLayoutPosition(
2323
axis, direction, containingBlockWidth) +
2424
parent->getLayout().border(flexStartEdge(axis));
2525

26+
// https://www.w3.org/TR/css-grid-1/#abspos
27+
// absolute positioned grid items are positioned relative to the padding edge of the grid container
2628
if (!child->hasErrata(Errata::AbsolutePositionWithoutInsetsExcludesPadding) &&
2729
parent->style().display() != Display::Grid) {
2830
position += parent->getLayout().padding(flexStartEdge(axis));
@@ -41,6 +43,8 @@ static inline void setFlexEndLayoutPosition(
4143
child->style().computeFlexEndMargin(
4244
axis, direction, containingBlockWidth);
4345

46+
// https://www.w3.org/TR/css-grid-1/#abspos
47+
// absolute positioned grid items are positioned relative to the padding edge of the grid container
4448
if (!child->hasErrata(Errata::AbsolutePositionWithoutInsetsExcludesPadding) &&
4549
parent->style().display() != Display::Grid) {
4650
flexEndPosition += parent->getLayout().padding(flexEndEdge(axis));
@@ -62,6 +66,8 @@ static inline void setCenterLayoutPosition(
6266
parent->getLayout().border(flexStartEdge(axis)) -
6367
parent->getLayout().border(flexEndEdge(axis));
6468

69+
// https://www.w3.org/TR/css-grid-1/#abspos
70+
// absolute positioned grid items are positioned relative to the padding edge of the grid container
6571
if (!child->hasErrata(Errata::AbsolutePositionWithoutInsetsExcludesPadding) &&
6672
parent->style().display() != Display::Grid) {
6773
parentContentBoxSize -= parent->getLayout().padding(flexStartEdge(axis));
@@ -77,6 +83,8 @@ static inline void setCenterLayoutPosition(
7783
child->style().computeFlexStartMargin(
7884
axis, direction, containingBlockWidth);
7985

86+
// https://www.w3.org/TR/css-grid-1/#abspos
87+
// absolute positioned grid items are positioned relative to the padding edge of the grid container
8088
if (!child->hasErrata(Errata::AbsolutePositionWithoutInsetsExcludesPadding) &&
8189
parent->style().display() != Display::Grid) {
8290
position += parent->getLayout().padding(flexStartEdge(axis));

yoga/algorithm/grid/TrackSizing.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,8 @@ struct TrackSizing {
301301
}
302302
}
303303
}
304-
304+
305+
// https://www.w3.org/TR/css-grid-1/#algo-single-span-items
305306
// https://www.w3.org/TR/css-grid-1/#algo-spanning-items
306307
void accomodateSpanningItemsCrossingContentSizedTracks(Dimension dimension) {
307308
if (!hasIntrinsicTracks) {

0 commit comments

Comments
 (0)