Skip to content

Commit 5366a48

Browse files
early exit in contribution changed
1 parent 306223f commit 5366a48

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

yoga/algorithm/grid/AutoPlacement.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -445,10 +445,10 @@ struct GridItem {
445445
// https://www.w3.org/TR/css-grid-1/#algo-baseline-shims
446446
float baselineShim = 0.0f;
447447
// Flags used for optimisations in TrackSizing
448-
float crossesIntrinsicRow = false;
449-
float crossesIntrinsicColumn = false;
450-
float crossesFlexibleRow = false;
451-
float crossesFlexibleColumn = false;
448+
bool crossesIntrinsicRow = false;
449+
bool crossesIntrinsicColumn = false;
450+
bool crossesFlexibleRow = false;
451+
bool crossesFlexibleColumn = false;
452452

453453
GridItem(
454454
size_t columnStart,

yoga/algorithm/grid/TrackSizing.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1833,6 +1833,10 @@ struct TrackSizing {
18331833
Dimension dimension,
18341834
CrossDimensionEstimator estimatorBefore,
18351835
CrossDimensionEstimator estimatorAfter) {
1836+
auto hasNonFixedTracks = dimension == Dimension::Width ? hasNonFixedColumnTracks : hasNonFixedRowTracks;
1837+
if (!hasNonFixedTracks) {
1838+
return false;
1839+
}
18361840
for (const auto& item : gridItems) {
18371841
if (!item.crossesIntrinsicTrack(dimension)) {
18381842
continue;

0 commit comments

Comments
 (0)