Skip to content

Commit 8339d99

Browse files
William Khoefacebook-github-bot
authored andcommitted
Back out "Add fixYogaFlexBasisFitContentInMainAxis flag to avoid unnecessary re-measurement"
Summary: Backing out the following pull due to bugs * #1909 * facebook/react-native#55897 Reviewed By: sammy-SC Differential Revision: D95616085
1 parent 8484a8c commit 8339d99

14 files changed

Lines changed: 16 additions & 1829 deletions

File tree

enums.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,6 @@
8383
# Absolute nodes will resolve percentages against the inner size of
8484
# their containing node, not the padding box
8585
("AbsolutePercentAgainstInnerSize", 1 << 2),
86-
# Applies a FitContent constraint in the main axis during flex basis
87-
# computation for non-measure container nodes
88-
("FlexBasisFitContentInMainAxis", 1 << 3),
8986
# Enable all incorrect behavior (preserve compatibility)
9087
("All", 0x7FFFFFFF),
9188
# Enable all errata except for "StretchFlexBasis" (Defaults behavior

gentest/fixtures/YGFlexBasisFitContentInMainAxisTest.html

Lines changed: 0 additions & 68 deletions
This file was deleted.

java/com/facebook/yoga/YogaErrata.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ public enum YogaErrata {
1414
STRETCH_FLEX_BASIS(1),
1515
ABSOLUTE_POSITION_WITHOUT_INSETS_EXCLUDES_PADDING(2),
1616
ABSOLUTE_PERCENT_AGAINST_INNER_SIZE(4),
17-
FLEX_BASIS_FIT_CONTENT_IN_MAIN_AXIS(8),
1817
ALL(2147483647),
1918
CLASSIC(2147483646);
2019

@@ -34,7 +33,6 @@ public static YogaErrata fromInt(int value) {
3433
case 1: return STRETCH_FLEX_BASIS;
3534
case 2: return ABSOLUTE_POSITION_WITHOUT_INSETS_EXCLUDES_PADDING;
3635
case 4: return ABSOLUTE_PERCENT_AGAINST_INNER_SIZE;
37-
case 8: return FLEX_BASIS_FIT_CONTENT_IN_MAIN_AXIS;
3836
case 2147483647: return ALL;
3937
case 2147483646: return CLASSIC;
4038
default: throw new IllegalArgumentException("Unknown enum value: " + value);

0 commit comments

Comments
 (0)