fix: store dynamic value ids as uint32_t

paradowstack · paradowstack · commit ed48c0699c8d · 2026-03-20T13:02:50.000-03:00
diff --git a/yoga/YGValue.h b/yoga/YGValue.h
@@ -58,7 +58,7 @@ YG_EXPORT bool YGFloatIsUndefined(float value);
 /**
  * Host-defined identifier for a dynamic style value.
  */
-typedef uint8_t YGValueDynamicID;
+typedef uint32_t YGValueDynamicID;
 
 /**
  * Layout context passed to YGValueDynamic for resolving dynamic values.
diff --git a/yoga/style/StyleValuePool.h b/yoga/style/StyleValuePool.h
@@ -200,7 +200,7 @@ class StyleValuePool {
   YGValueDynamicID getDynamicCallbackID(StyleValueHandle handle) const {
     assert(handle.isDynamic());
     assert(handle.isValueIndexed());
-    return static_cast<uint8_t>(buffer_.get32(handle.value() + 2));
+    return buffer_.get32(handle.value() + 2);
   }
 
   static constexpr bool isIntegerPackable(float f) {

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ class StyleValuePool {`
`200`	`200`	`YGValueDynamicID getDynamicCallbackID(StyleValueHandle handle) const {`
`201`	`201`	`assert(handle.isDynamic());`
`202`	`202`	`assert(handle.isValueIndexed());`
`203`		`- return static_cast<uint8_t>(buffer_.get32(handle.value() + 2));`
	`203`	`+ return buffer_.get32(handle.value() + 2);`
`204`	`204`	`}`
`205`	`205`
`206`	`206`	`static constexpr bool isIntegerPackable(float f) {`