[Bug]: Does not work with Magento2.4.4 ECE , it shows all pages blank

[vardhmankamani1]

Contact Details

No response

What happened?

I Installed Facebook Business Extension(1.4.5) on the frontend all pages are blank and showing below error During inheritance of ArrayAccess: Uncaught Exception: Deprecated Functionality: Return type of FacebookAds\Object\ServerSide\AdsPixelSettings::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

Magento Version

2.4.4

Plugin Version

1.4.5

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[angelo983]

Given the low consideration that the facebook dev team is giving to this topic, here is the solution for compatibility with php 8.1.
Declare return types in:

-row 154
public function offsetExists($offset): bool {

-row 163
public function offsetGet($offset): mixed {

-row 173
public function offsetSet($offset, $value): void {

-row 186
public function offsetUnset($offset): void {

[angelo983]

As for:
AdsPixelSettings.php
similar corrections need to be made urgently also in:
Content.php
CustomData.php
Event.php
EventRequest.php
UserData.php

[angelo983]

/vendor/facebook/facebook-for-magento2/Helper/MagentoDataHelper.php on line 481 missing empty string control.

/vendor/facebook/facebook-for-magento2/Model/Feed/CategoryCollection.php on line 306 missing is_array control.

[davirs]

This is a critical issue!
All new stores since 2022 are using php 8.1 and gradually the past versions lose support.
It is unbelievable that a company that makes billions of dollars has no budget to solve simple compatibility problems!

@angelo983 , Were you able to resolve to make the module usable?

[angelo983]

This is a critical issue! All new stores since 2022 are using php 8.1 and gradually the past versions lose support. It is unbelievable that a company that makes billions of dollars has no budget to solve simple compatibility problems!

@angelo983 , Were you able to resolve to make the module usable?

Yes @davirs but I'm still monitoring if data are correctly sent to the Server Pixel

[angelo983]

/var/log/facebook-business-extension.log grows rapidly

php-fpm_error.log is continously spammed by this string:
WARNING: [pool domain.com] child 123456 said into stdout: "FacebookAds\CrashReporter : Enabled"

about 40.000 rows per day

[angelo983]

vendor/facebook/facebook-for-magento2/Logger/Handler.php
protected $loggerType = Logger::INFO;
in a production environment??? CRAZY CRAZY CRAZY

[dankocrama]

@zlik Same error here why Facebook is not updating the module to have support for php 8.1 ?

[eugenegordienko]

@xiangminxufsu @zlik @josejia @fbisaso is there any news regarding this issue?

[mrramanathan31]

@vardhmankamani1 Getting the same issue in Magento 2.4.5-p1 Enterprise edition. Did you get a chance to resolve this? Any suggestion or solution ???

[vardhmankamani1]

Hello @mrramanathan31 Yes, We created the custom patch for that and now we are testing the module. The following file you need to modify.

vendor/facebook/php-business-sdk/src/FacebookAds/Object/ServerSide/Event.php

-  public function offsetExists($offset) {
+  public function offsetExists($offset): bool {

-  public function offsetGet($offset) {
+  public function offsetGet($offset): mixed {

-  public function offsetSet($offset, $value) {
+  public function offsetSet($offset, $value): void {

-  public function offsetUnset($offset) {
+  public function offsetUnset($offset): void {

vendor/facebook/php-business-sdk/src/FacebookAds/Object/ServerSide/Content.php

-  public function offsetExists($offset) {
+  public function offsetExists($offset): bool {

-  public function offsetGet($offset) {
+  public function offsetGet($offset): mixed {

-  public function offsetSet($offset, $value) {
+  public function offsetSet($offset, $value): void {

-  public function offsetUnset($offset) {
+  public function offsetUnset($offset): void {

vendor/facebook/php-business-sdk/src/FacebookAds/Object/ServerSide/UserData.php

-  public function offsetExists($offset) {
+  public function offsetExists($offset): bool {

-  public function offsetGet($offset) {
+  public function offsetGet($offset): mixed {

-  public function offsetSet($offset, $value) {
+  public function offsetSet($offset, $value): void {

-  public function offsetUnset($offset) {
+  public function offsetUnset($offset): void {

vendor/facebook/php-business-sdk/src/FacebookAds/Object/ServerSide/CustomData.php

-  public function offsetExists($offset) {
+  public function offsetExists($offset): bool {

-  public function offsetGet($offset) {
+  public function offsetGet($offset): mixed {

-  public function offsetSet($offset, $value) {
+  public function offsetSet($offset, $value): void {

-  public function offsetUnset($offset) {
+  public function offsetUnset($offset): void {

vendor/facebook/php-business-sdk/src/FacebookAds/Object/ServerSide/EventRequest.php

-  public function offsetExists($offset) {
+  public function offsetExists($offset): bool {

-  public function offsetGet($offset) {
+  public function offsetGet($offset): mixed {

-  public function offsetSet($offset, $value) {
+  public function offsetSet($offset, $value): void {

-  public function offsetUnset($offset) {
+  public function offsetUnset($offset): void {

vendor/facebook/php-business-sdk/src/FacebookAds/Object/ServerSide/AdsPixelSettings.php

-  public function offsetExists($offset) {
+  public function offsetExists($offset): bool {

-  public function offsetGet($offset) {
+  public function offsetGet($offset): mixed {

-  public function offsetGet($offset) {
+  public function offsetGet($offset): mixed {

-  public function offsetSet($offset, $value) {
+  public function offsetSet($offset, $value): void {

-  public function offsetUnset($offset) {
+  public function offsetUnset($offset): void {

vendor/facebook/facebook-for-magento2/Model/Feed/CategoryCollection.php

-        $response_obj = json_decode($response, true);
+        $response_obj = json_decode($response, true)??[];

vendor/facebook/facebook-for-magento2/Helper/MagentoDataHelper.php

-        return hash('sha256', strtolower($string));
+        return hash('sha256', strtolower($string??''));

[Ig0r-M-magic42]

@vardhmankamani1 given you have listed the files to be edited in #119 (comment) and mentioned that a custom patch has been created could you please provide so that we could apply it using https://github.com/cweagans/composer-patches

[Ig0r-M-magic42]

Update for those interested below are the .patch files based on recommended changes from #119 (comment)

• Patch for facebook for magento2
• Patch for php business sdk

[Ig0r-M-magic42]

Updated above comment to include file src/FacebookAds/Object/ServerSide/AdsPixelSettings.php as well