Merge pull request #694 from calgray/main

- io_uring_context with non-TU local c++23 htons implementation
- added gcc14 in C++23 mode to CI (clang still TODO, blocked by issue with gtest)

Author: MaxMotovilov

.github/workflows/libunifex-ci.yml

@@ -3,15 +3,13 @@ name: libunifex CI
 # Trigger on pushes to all branches and for all pull-requests
 on: [push, pull_request]
 
-env:
-  CMAKE_VERSION: 3.16.2
-  NINJA_VERSION: 1.9.0
-
-
 jobs:
   build:
     name: ${{ matrix.config.name }}
     runs-on: ${{ matrix.config.os }}
+    env:
+      CMAKE_VERSION: ${{ matrix.config.cmake_version || '3.16.2' }}
+      NINJA_VERSION: ${{ matrix.config.ninja_version || '1.9.0' }}
     strategy:
       fail-fast: false
       matrix:
@@ -152,6 +150,33 @@ jobs:
             cc: "gcc-14", cxx: "g++-14",
             cmake_args: "-D CMAKE_CXX_STANDARD:STRING=20 -D CMAKE_CXX_FLAGS=-fno-exceptions"
           }
+        - {
+            name: "Linux GCC 14 Debug (C++23)", artifact: "Linux.tar.xz",
+            os: ubuntu-24.04,
+            io_sys: io_uring,
+            build_type: Debug,
+            cc: "gcc-14", cxx: "g++-14",
+            cmake_version: "3.20.0",
+            cmake_args: "-D CMAKE_CXX_STANDARD:STRING=23"
+          }
+        - {
+            name: "Linux GCC 14 Optimised (C++23)", artifact: "Linux.tar.xz",
+            os: ubuntu-24.04,
+            io_sys: io_uring,
+            build_type: RelWithDebInfo,
+            cc: "gcc-14", cxx: "g++-14",
+            cmake_version: "3.20.0",
+            cmake_args: "-D CMAKE_CXX_STANDARD:STRING=23"
+          }
+        - {
+            name: "Linux GCC 14 Optimised noexcept (C++23)", artifact: "Linux.tar.xz",
+            os: ubuntu-24.04,
+            io_sys: io_uring,
+            build_type: RelWithDebInfo,
+            cc: "gcc-14", cxx: "g++-14",
+            cmake_version: "3.20.0",
+            cmake_args: "-D CMAKE_CXX_STANDARD:STRING=23 -D CMAKE_CXX_FLAGS=-fno-exceptions"
+          }
         - {
             name: "Linux Clang 15 Debug (C++17)", artifact: "Linux.tar.xz",
             os: ubuntu-22.04,
@@ -414,7 +439,11 @@ jobs:
         elseif ("${{ runner.os }}" STREQUAL "Linux")
           set(ninja_suffix "linux.zip")
           set(cmake_suffix "Linux-x86_64.tar.gz")
-          set(cmake_dir "cmake-${cmake_version}-Linux-x86_64/bin")
+          if(cmake_version VERSION_GREATER_EQUAL 3.20.0)
+            set(cmake_dir "cmake-${cmake_version}-linux-x86_64/bin")
+          else()
+            set(cmake_dir "cmake-${cmake_version}-Linux-x86_64/bin")
+          endif()
         elseif ("${{ runner.os }}" STREQUAL "macOS")
           set(ninja_suffix "mac.zip")
           set(cmake_suffix "Darwin-x86_64.tar.gz")

include/unifex/linux/io_uring_context.hpp

@@ -52,6 +52,9 @@
 #  include <sys/socket.h>
 #  include <sys/uio.h>
 #  include <unistd.h>
+#  if __has_include(<bit>)
+#  include <bit>
+#  endif // __has_include(<bit>)
 
 #  include <unifex/detail/prologue.hpp>
 
@@ -1351,6 +1354,20 @@ class io_uring_context::accept_stream {
   port_t port_;
   safe_file_descriptor fd_;
 
+# if __cpp_lib_byteswap >= 202110L
+  static constexpr std::uint16_t host_to_network(std::uint16_t value) {
+      return (
+        std::endian::native == std::endian::little
+          ? std::byteswap(value)
+          : value
+      );
+  }
+# else
+  static std::uint16_t host_to_network(std::uint16_t value) {
+    return htons(value);
+  }
+# endif // __cpp_lib_byteswap
+
   // TODO should this run on the io_context? If so, why?
   void open_socket() noexcept {
     // both IPv4 and IPv6
@@ -1365,7 +1382,7 @@ class io_uring_context::accept_stream {
     UNIFEX_ASSERT(ret != -1);
 
     addr.sin6_family = AF_INET6;
-    addr.sin6_port = htons(port_);
+    addr.sin6_port = host_to_network(port_);
     addr.sin6_addr = in6addr_any;
     ret = bind(fd_.get(), (const struct sockaddr*)&addr, sizeof(addr));
     UNIFEX_ASSERT(ret != -1);
@@ -1379,4 +1396,4 @@ class io_uring_context::accept_stream {
 
 #  include <unifex/detail/epilogue.hpp>
 
-#endif  // __has_include(<liburing.h>)
+#endif // UNIFEX_NO_LIBURING