Skip to content

Commit 25c3d71

Browse files
gmarzotmeta-codesync[bot]
authored andcommitted
Fix cmake config: find_dependency(fizz) before wangle (#109)
Summary: `wangle-targets.cmake` checks for `fizz::fizz` targets at include time. When a downstream consumer calls `find_package(moxygen)`, `moxygen-config.cmake` calls `find_dependency(wangle)` which includes `wangle-targets.cmake`. If fizz has not yet been loaded at that point, the target existence check fails and `wangle_FOUND` is set to `FALSE`. Fix: add `find_dependency(fizz)` between folly and wangle so fizz targets exist before wangle's cmake files check for them. Pull Request resolved: #109 Reviewed By: sharmafb Differential Revision: D95313015 Pulled By: afrind fbshipit-source-id: cf793b2d4b9d8c3b3ce978c0463f8086ab9eadb4
1 parent 1499053 commit 25c3d71

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

cmake/moxygen-config.cmake.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
include(CMakeFindDependencyMacro)
1515
find_dependency(folly)
16+
find_dependency(fizz)
1617
find_dependency(wangle)
1718
find_dependency(mvfst)
1819
find_dependency(proxygen)

0 commit comments

Comments
 (0)