use explicit types in Cursor::write in ti/

Summary:
Addresses problems like this:

```
void* buf = /*...*/;
uint16_t word = /*...*/;
cursor.write(word & 0xffff); // oops, 32-bit store due to implicit integer promotion
```

Differential Revision: D94252970

fbshipit-source-id: c7caa45e204b3c8975e18145b07c3d1c9a578009

Author: yfeldblum

moxygen/MoQFramer.cpp

@@ -3429,7 +3429,7 @@ void writeVarint(
   }
   folly::io::QueueAppender appender(&buf, kMaxFrameHeaderSize);
   auto appenderOp = [appender = std::move(appender)](auto val) mutable {
-    appender.writeBE(val);
+    appender.writeBE(folly::tag<decltype(val)>, val);
   };
   auto res = quic::encodeQuicInteger(value, appenderOp);
   if (res.hasError()) {

moxygen/moq_mi/MoQMi.cpp

@@ -442,7 +442,7 @@ void MoQMi::writeVarint(
   }
   folly::io::QueueAppender appender(&buf, MoQMi::kMaxQuicIntSize);
   auto appenderOp = [appender = std::move(appender)](auto val) mutable {
-    appender.writeBE(val);
+    appender.writeBE(folly::tag<decltype(val)>, val);
   };
   auto res = quic::encodeQuicInteger(value, appenderOp);
   if (res.hasError()) {

moxygen/samples/hack/MoQVideoPublisher.cpp

@@ -92,7 +92,7 @@ std::unique_ptr<folly::IOBuf> serializeAVCDecoderConfigurationRecord(
   folly::io::Appender appender(configRecord.get(), 1024);
 
   // Configuration record header (ISO/IEC 14496-15 AVC file format)
-  appender.writeBE<uint8_t>(1); // configurationVersion_
+  appender.writeBE<uint8_t>(static_cast<uint8_t>(1)); // configurationVersion_
 
   // Get profile/level from first SPS
   folly::io::Cursor spsCursor(spsNalus.data());
@@ -107,21 +107,24 @@ std::unique_ptr<folly::IOBuf> serializeAVCDecoderConfigurationRecord(
 
   // 6 bits reserved (111111 = 0xFC) + 2 bits NAL length size - 1
   const uint8_t lengthSizeMinusOne = 3; // Using 4 byte NAL length size
-  appender.writeBE<uint8_t>(0xFC | lengthSizeMinusOne);
+  appender.writeBE<uint8_t>(static_cast<uint8_t>(0xFC | lengthSizeMinusOne));
 
   // 3 bits reserved (111 = 0xE0) + 5 bits number of SPS NALUs
-  appender.writeBE<uint8_t>(0xE0 | (spsNalus.size() & 0x1F));
+  appender.writeBE<uint8_t>(
+      static_cast<uint8_t>(0xE0 | (spsNalus.size() & 0x1F)));
 
   // Write SPS NALUs
   for (const auto& sps : spsNalus) {
-    appender.writeBE<uint16_t>(sps.computeChainDataLength());
+    appender.writeBE<uint16_t>(
+        static_cast<uint16_t>(sps.computeChainDataLength()));
     appender.push(sps.data(), sps.computeChainDataLength());
   }
 
   // Write PPS count and NALUs
-  appender.writeBE<uint8_t>(ppsNalus.size());
+  appender.writeBE<uint8_t>(static_cast<uint8_t>(ppsNalus.size()));
   for (const auto& pps : ppsNalus) {
-    appender.writeBE<uint16_t>(pps.computeChainDataLength());
+    appender.writeBE<uint16_t>(
+        static_cast<uint16_t>(pps.computeChainDataLength()));
     appender.push(pps.data(), pps.computeChainDataLength());
   }
 
@@ -130,13 +133,13 @@ std::unique_ptr<folly::IOBuf> serializeAVCDecoderConfigurationRecord(
       AVCProfileIndication != 77 && // Main
       AVCProfileIndication != 88) { // Extended
     // 6 bits reserved (111111) + 2 bits chroma format (typically 1 = 4:2:0)
-    appender.writeBE<uint8_t>(0xFC | 1);
+    appender.writeBE<uint8_t>(static_cast<uint8_t>(0xFC | 1));
     // 5 bits reserved (11111) + 3 bits bit depth luma minus 8 (typically 0)
-    appender.writeBE<uint8_t>(0xF8);
+    appender.writeBE<uint8_t>(static_cast<uint8_t>(0xF8));
     // 5 bits reserved (11111) + 3 bits bit depth chroma minus 8 (typically 0)
-    appender.writeBE<uint8_t>(0xF8);
+    appender.writeBE<uint8_t>(static_cast<uint8_t>(0xF8));
     // Number of SPS Ext NALUs (typically 0)
-    appender.writeBE<uint8_t>(0);
+    appender.writeBE<uint8_t>(static_cast<uint8_t>(0));
   }
 
   return configRecord;

moxygen/test/MoQFramerTest.cpp

@@ -20,7 +20,7 @@ namespace {
 inline void writeVarintTo(folly::IOBufQueue& q, uint64_t v) {
   folly::io::QueueAppender appender(&q, kMaxFrameHeaderSize);
   auto appenderOp = [appender = std::move(appender)](auto val) mutable {
-    appender.writeBE(val);
+    appender.writeBE(folly::tag<decltype(val)>, val);
   };
   (void)quic::encodeQuicInteger(v, appenderOp);
 }
@@ -475,7 +475,7 @@ TEST(MoQFramerTest, ParseClientSetupWithUnknownAndSupportedVersions) {
   folly::IOBufQueue patchBuf{folly::IOBufQueue::cacheChainLength()};
   folly::io::QueueAppender appender(&patchBuf, kMaxFrameHeaderSize);
   XCHECK(quic::encodeQuicInteger(kVersionDraft03, [&](auto val) {
-    appender.writeBE(val);
+    appender.writeBE(folly::tag<decltype(val)>, val);
   }));
   auto patchIOBuf = patchBuf.move();
 
@@ -570,7 +570,7 @@ TEST_P(MoQFramerTest, parseFixedString) {
   CHECK(
       quic::encodeQuicInteger(
           s.length(), [appender = std::move(appender)](auto val) mutable {
-            appender.writeBE(val);
+            appender.writeBE(folly::tag<decltype(val)>, val);
           }));
 
   // Write a blob of bytes to buffer