Update MOQTPublishDone structure

Summary: I'm updating the `MOQTPublishDone` structure to be in line with the specification.

Reviewed By: afrind

Differential Revision: D88779365

fbshipit-source-id: 1f12cd01f4b501af0023a2153f158c3fb63dcc5c

Author: Aman Sharma

moxygen/MoQSession.cpp

@@ -3619,7 +3619,7 @@ void MoQSession::onSubscribeDone(SubscribeDone subscribeDone) {
              << " reason=" << subscribeDone.reasonPhrase;
 
   if (logger_) {
-    logger_->logSubscribeDone(subscribeDone, ControlMessageType::PARSED);
+    logger_->logPublishDone(subscribeDone, ControlMessageType::PARSED);
   }
   MOQ_SUBSCRIBER_STATS(
       subscriberStatsCallback_, onSubscribeDone, subscribeDone.statusCode);
@@ -4466,7 +4466,7 @@ void MoQSession::sendSubscribeDone(const SubscribeDone& subDone) {
   }
 
   if (logger_) {
-    logger_->logSubscribeDone(subDone);
+    logger_->logPublishDone(subDone);
   }
   controlWriteEvent_.signal();
   retireRequestID(/*signalWriteLoop=*/false);

moxygen/mlog/MLogTypes.cpp

@@ -368,17 +368,17 @@ folly::dynamic MOQTFetchError::toDynamic() const {
   return obj;
 }
 
-folly::dynamic MOQTSubscribeDone::toDynamic() const {
+folly::dynamic MOQTPublishDone::toDynamic() const {
   folly::dynamic obj = folly::dynamic::object;
   obj["type"] = type;
-  obj["subscribeId"] = std::to_string(subscribeId);
-  obj["statusCode"] = std::to_string(statusCode);
-  obj["streamCount"] = std::to_string(streamCount);
+  obj["request_id"] = requestId;
+  obj["status_code"] = statusCode;
+  obj["stream_count"] = streamCount;
   if (reason.hasValue()) {
     obj["reason"] = reason.value();
   }
   if (reasonBytes.hasValue()) {
-    obj["reasonBytes"] = reasonBytes.value();
+    obj["reason_bytes"] = reasonBytes.value();
   }
   return obj;
 }

moxygen/mlog/MLogTypes.h

@@ -347,13 +347,13 @@ class MOQTFetchError : public MOQTBaseControlMessage {
   folly::Optional<std::string> reasonBytes;
 };
 
-class MOQTSubscribeDone : public MOQTBaseControlMessage {
+class MOQTPublishDone : public MOQTBaseControlMessage {
  public:
-  MOQTSubscribeDone() {
-    type = "subscribe_done";
+  MOQTPublishDone() {
+    type = "publish_done";
   }
   folly::dynamic toDynamic() const override;
-  uint64_t subscribeId{0};
+  uint64_t requestId{0};
   uint64_t statusCode{};
   uint64_t streamCount{};
   folly::Optional<std::string> reason;

moxygen/mlog/MLogger.cpp

@@ -514,11 +514,11 @@ void MLogger::logFetchError(
       controlType, kFirstBidiStreamId, folly::none, std::move(baseMsg));
 }
 
-void MLogger::logSubscribeDone(
+void MLogger::logPublishDone(
     const SubscribeDone& req,
     ControlMessageType controlType) {
-  auto baseMsg = std::make_unique<MOQTSubscribeDone>();
-  baseMsg->subscribeId = req.requestID.value;
+  auto baseMsg = std::make_unique<MOQTPublishDone>();
+  baseMsg->requestId = req.requestID.value;
   baseMsg->statusCode = static_cast<uint64_t>(req.statusCode);
   baseMsg->streamCount = req.streamCount;
 

moxygen/mlog/MLogger.h

@@ -111,7 +111,7 @@ class MLogger {
   void logFetchError(
       const FetchError& req,
       ControlMessageType controlType = ControlMessageType::CREATED);
-  void logSubscribeDone(
+  void logPublishDone(
       const SubscribeDone& req,
       ControlMessageType controlType = ControlMessageType::CREATED);
   void logMaxRequestId(