Skip to content

Commit de9402c

Browse files
r-barnesmeta-codesync[bot]
authored andcommitted
rebalancer manifest: enable position-independent code by default
Summary: Add [cmake.defines] CMAKE_POSITION_INDEPENDENT_CODE=ON so that rebalancer's library archives are PIC. This is required because librebalancer.so is now built as a shared library; without PIC the final link fails with R_X86_64_PC32 / 'recompile with -fPIC' against its own intermediate object files. Reviewed By: uhebertj Differential Revision: D103767968 fbshipit-source-id: 05f290f6576fd843805b2dbeb8dd097a9f0de7e1
1 parent 5e46376 commit de9402c

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

build/fbcode_builder/manifests/rebalancer

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ branch = main
1414
[build]
1515
builder = cmake
1616

17+
[cmake.defines]
18+
CMAKE_POSITION_INDEPENDENT_CODE=ON
19+
1720
[dependencies]
1821
boost
1922
fbthrift

0 commit comments

Comments
 (0)