Skip to content

Commit 8f47632

Browse files
njriasanmeta-codesync[bot]
authored andcommitted
[AMD][Triton] Fix C++ compilation errors in generated launcher code (#1212)
Summary: Pull Request resolved: #1212 The AMD Triton backend generates C++ launcher code at runtime that failed to compile with clang-20 in strict C++ mode due to: - Enum type mismatch: HIP_SUCCESS vs hipSuccess - Implicit int-to-enum assignment for hipLaunchAttributeID - Narrowing int-to-unsigned-int conversions in HIP_LAUNCH_CONFIG initializer ___ overriding_review_checks_triggers_an_audit_and_retroactive_review Oncall Short Name: triton Reviewed By: agron911, yvonne-lab Differential Revision: D100046561 fbshipit-source-id: bb4c8af33d5339f813a53a3b0948310ada4d77b9
1 parent b0490dc commit 8f47632

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

third_party/amd/backend/driver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,7 @@ def format_of(ty):
475475
476476
static inline void gpuAssert(hipError_t code, const char *file, int line)
477477
{{
478-
if (code != HIP_SUCCESS)
478+
if (code != hipSuccess)
479479
{{
480480
const char* prefix = "Triton Error [HIP]: ";
481481
const char* str = hipSymbolTable.hipGetErrorString(code);

0 commit comments

Comments
 (0)