This repository was archived by the owner on Aug 8, 2025. It is now read-only.
This repository was archived by the owner on Aug 8, 2025. It is now read-only.
return in finally swallows exceptions #151
Description
In
Line 88 in 92c9eeb
return statement in a finally block, which would swallow any in-flight exception.
This means that if an unhandled exception (including a BaseException such as KeyboardInterrupt) is raised from the try body, or any exception is raised from an except: clause, it will not propagate on as expected.
If the intention is to suppress all exceptions, I would propose to make this clear by using "except BaseException".
See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.