Replace tab indentation with 4 spaces

The repo standard is spaces: .editorconfig sets indent_style = space /
indent_size = 4, and phpcs.xml enables Generic.WhiteSpace.DisallowTabIndent
plus ScopeIndent with tabIndent=false. Five changed files had slipped
through:

- facebook-for-wordpress.php carries a // phpcs:ignoreFile, so it is never
  linted. Also adds the missing blank line after the new $tracking_facade
  property and drops a whitespace-only line.
- __tests__/* is excluded in phpcs.xml, so TrackableLeadFormMappingTest was
  unchecked.
- In Pixel and TrackableIntegrationBase the tabs sat inside the multi-line
  printf()/sprintf() markup templates rather than in code indentation, so
  the sniff never saw them; only the emitted whitespace changes.
- composer.json had one pre-existing tab on the phpunit require-dev line.

No behavior change.

Author: vahidkay-meta

__tests__/integration/TrackableLeadFormMappingTest.php

@@ -24,27 +24,27 @@
  */
 final class TrackableLeadFormMappingTest extends FacebookWordpressTestBase {
 
-	/**
-	 * When a form field is mapped to a composite Lead parameter (e.g. an
-	 * address), apply_field_mapping() should expand it into its sub-parameters
-	 * (city/state/zip/country) rather than assigning the raw composite value.
-	 *
-	 * This is not implemented yet: apply_field_mapping() currently does a flat
-	 * assignment, and composite targets aren't in VALID_LEAD_PARAMETERS. It is
-	 * blocked on the mapping UI, which will define how composite fields declare
-	 * their sub-field targets. See the TODO(mapping-UI) note in
-	 * TrackableLeadFormIntegrationBase::apply_field_mapping().
-	 *
-	 * Intended assertions once implemented: mapping an 'address' form field
-	 * should yield lead data with 'city', 'state', 'zip', and 'country' keys.
-	 *
-	 * @return void
-	 */
-	public function testCompositeAddressMappingIsExpanded() {
-		$this->markTestIncomplete(
-			'Composite (address) field mapping breakdown is pending the mapping '
-			. 'UI. See TrackableLeadFormIntegrationBase::apply_field_mapping '
-			. 'TODO(mapping-UI).'
-		);
-	}
+    /**
+     * When a form field is mapped to a composite Lead parameter (e.g. an
+     * address), apply_field_mapping() should expand it into its sub-parameters
+     * (city/state/zip/country) rather than assigning the raw composite value.
+     *
+     * This is not implemented yet: apply_field_mapping() currently does a flat
+     * assignment, and composite targets aren't in VALID_LEAD_PARAMETERS. It is
+     * blocked on the mapping UI, which will define how composite fields declare
+     * their sub-field targets. See the TODO(mapping-UI) note in
+     * TrackableLeadFormIntegrationBase::apply_field_mapping().
+     *
+     * Intended assertions once implemented: mapping an 'address' form field
+     * should yield lead data with 'city', 'state', 'zip', and 'country' keys.
+     *
+     * @return void
+     */
+    public function testCompositeAddressMappingIsExpanded() {
+        $this->markTestIncomplete(
+            'Composite (address) field mapping breakdown is pending the mapping '
+            . 'UI. See TrackableLeadFormIntegrationBase::apply_field_mapping '
+            . 'TODO(mapping-UI).'
+        );
+    }
 }

composer.json

@@ -9,7 +9,7 @@
     "wp-coding-standards/wpcs": "^3.1",
     "symfony/finder": "~2.6",
     "mockery/mockery": "^1.6",
-	"phpunit/phpunit": "~9",
+    "phpunit/phpunit": "~9",
     "dealerdirect/phpcodesniffer-composer-installer": "^1.0",
     "php-stubs/wordpress-stubs": "^7.0"
   },

core/signals/class-pixel.php

@@ -160,9 +160,9 @@ public function print_out_pending_dom_elements() {
         $pixel_dom = $this->generate_script_for_tracked_events( true );
         printf(
             '
-			<!-- Meta Pixel Event Code -->
-			%s
-			<!-- End Meta Pixel Event Code -->',
+            <!-- Meta Pixel Event Code -->
+            %s
+            <!-- End Meta Pixel Event Code -->',
             $pixel_dom // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- Pixel DOM is plugin-generated script, not user input.
         );
     }

facebook-for-wordpress.php

@@ -60,8 +60,9 @@
  * FacebookForWordpress root class.
  */
 class FacebookForWordpress {
-	private $tracking_facade;
-	/**
+    private $tracking_facade;
+
+    /**
      * Plugin constructor. Initializes the plugin options, loads the translation files,
      * sets up the Facebook pixel, sets up the pixel injection, and sets up the settings
      * page. Also starts the server event async task.
@@ -77,18 +78,18 @@ public function __construct() {
 
     $options = FacebookWordpressOptions::get_options();
 
-	$this->tracking_facade = new FacebookTrackingFacade(
-		FacebookWordpressOptions::get_agent_string(),
+    $this->tracking_facade = new FacebookTrackingFacade(
+        FacebookWordpressOptions::get_agent_string(),
         FacebookWordpressOptions::get_active_pixel_id()
-	);
-	
-	$this->tracking_facade->initialize();
+    );
+
+    $this->tracking_facade->initialize();
     $tracking_facade = $this->tracking_facade;
 
     // Initialize the third-party plugin integrations.
     add_action( 'init', function(...$args) use($tracking_facade) {
-		$this->initialize_integrations( $tracking_facade );
-	}, 0 );
+        $this->initialize_integrations( $tracking_facade );
+    }, 0 );
 
     add_action( 'parse_request', array( $this, 'handle_events_request' ), 0 );
 
@@ -98,9 +99,9 @@ public function __construct() {
     self::update_db_for_wpcom();
     }
 
-	public function get_tracking_facade() {
-		return $this->tracking_facade;
-	}
+    public function get_tracking_facade() {
+        return $this->tracking_facade;
+    }
 
     /**
      * Resets the FBL4B upgrade notice dismiss flag when the plugin is updated,

integration/class-trackableintegrationbase.php

@@ -171,10 +171,10 @@ protected function register_ajax_container( $listener_js ) {
         $this->signals->register_ajax_dom_container(
             sprintf(
                 "<!-- Meta Pixel Event Code -->
-				<script type='text/javascript'>
-				%s
-				</script>
-				<!-- End Meta Pixel Event Code -->",
+                <script type='text/javascript'>
+                %s
+                </script>
+                <!-- End Meta Pixel Event Code -->",
                 $listener_js
             )
         );