Since this is not a lib but actual plugin package, throwing exceptions should be prevented and should be handled in some other way as we don't have any control over it after the plugin is installed. A side from this, most of the users are not developers, and this is just causing them issues (error happened, something is wrong, I better uninstall/spam support/something 3rd)
I found it in here ed7519a that errors were logged, but then reverted back to be thrown. In this reverted scenario, our try/catch block is completely useless as it not doing anything (waste of CPU time).
Because all of this, I'm suggesting that this should be changed and handled properly, and also new tests should be added to cover this.
Since this is not a lib but actual plugin package, throwing exceptions should be prevented and should be handled in some other way as we don't have any control over it after the plugin is installed. A side from this, most of the users are not developers, and this is just causing them issues (error happened, something is wrong, I better uninstall/spam support/something 3rd)
I found it in here ed7519a that errors were logged, but then reverted back to be thrown. In this reverted scenario, our try/catch block is completely useless as it not doing anything (waste of CPU time).
Because all of this, I'm suggesting that this should be changed and handled properly, and also new tests should be added to cover this.