Skip to content

Commit 0026948

Browse files
amend_lines_on_revision_mismatch as DocumentSymbolsRequest option
Summary: This flag will be disabled by default, but enabled on requests from CodeHub. See diffs on top to see behavior, summary: If a file changed between the requested revision and the (best) indexed revision, the symbol index will contain erronous line locations, which makes CodeHub render the wrong symbol information. This feature will enable a heuristic where symbols in unchanged lines should keep the correct locations. Reviewed By: jjuliamolin, donsbot Differential Revision: D78732535 fbshipit-source-id: 0a8450d3d2a7fccbb794f08c22c8e3fd678110d0
1 parent 6e6df59 commit 0026948

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

glean/glass/if/glass.thrift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,9 @@ struct RequestOptions {
164164
struct FeatureFlags {
165165
// include xlang? default is false
166166
3: optional bool include_xlang_refs;
167+
168+
// attempt to amend line numbers when the requested and served revisions mismatch
169+
4: bool amend_lines_on_revision_mismatch = false;
167170
}
168171

169172
// List symbols in a file. Symbols are spans of one or more tokens Glean has

0 commit comments

Comments
 (0)