Skip to content

Commit 4c23f9b

Browse files
generatedunixname89002005232357facebook-github-bot
authored andcommitted
Revert D79466105
Summary: This diff reverts D79466105 false positive Depends on D79466105 Differential Revision: D79467372 fbshipit-source-id: 1eaab4f66dec134aead9686ccb2e3e2b402f03a3
1 parent 204fb7e commit 4c23f9b

1 file changed

Lines changed: 18 additions & 0 deletions

File tree

thrift/annotation/hack.thrift

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,3 +210,21 @@ struct ModuleInternal {}
210210
@scope.Service
211211
@scope.Function
212212
struct GenerateClientMethodsWithHeaders {}
213+
214+
/**
215+
* Generated Hack types are being changed to `final` by default.
216+
*
217+
* For existing thrift types that are inherited from and cannot be easily migrated,
218+
* use this annotation to make the generated class non-final.
219+
*/
220+
@scope.Structured
221+
struct MigrationBlockingAllowInheritance {}
222+
223+
/**
224+
* Hack Unions without the `protected` compiler option may rely on `fb_json_serialize` for JSON serialization.
225+
* Adding this annotation will implement the JSONSerializable Hack interface allowing `fb_json_serialize` to continue being used.
226+
*
227+
* Note: This should only be used for migration purposes. Use `JSONThriftSerializer` instead.
228+
*/
229+
@scope.Union
230+
struct MigrationBlockingLegacyJSONSerialization {}

0 commit comments

Comments
 (0)