add new visibility mode to schema

Summary:
Hack dbs are broken  https://www.internalfb.com/sandcastle/workflow/3855081281038068005

```

DB create failure: Exception {exception_message = "Error in fact. Expecting an expression of type:\n  enum { Private | Protected | Public | Internal | }\nwhich should be of the form:\n  number (< 4)\nin JSON term:\n  4\nin JSON term:\n  {\"id\":39193,\"key\":{\"declaration\":{\"id\":39191},\"signature\":{\"key\":{\"returnsTypeInfo\":{\"id\":39192},\"contexts\":[{\"key\":\"HH\\\\Contexts\\\\write_props\"}],\"returns\":{\"key\":\"EntSchemaConfig\"},\"parameters\":[]}},\"visibility\":4,\"isAbstract\":false,\"isAsync\":false,\"isFinal\":true,\"isStatic\":false,\"attributes\":[{\"key\":{\"name\":{\"key\":\"__Override\"},\"parameters\":[]}}],\"typeParams\":[]}}\NUL"}
```

This means that the visibility "4" is out of bounds.

This new value has been added manually here  https://fburl.com/code/65e2eb2g  but this should have been generated from the schema using the instruction at the top of the file.

Updating the schema should fix it.

Follow-up: regenerate the hack.ml binding from the code (even though it's probably a noop)

Reviewed By: simonhollis, malanka

Differential Revision: D78743083

fbshipit-source-id: b771226d52b2d5ade257256a0b81c6eaec8d94ec

Author: Philippe Bidinger

glean/glass/Glean/Glass/Pretty/Hack.hs

@@ -128,7 +128,7 @@ data PropertyMod   = PropertyMod Abstract Final Visibility Static
 
 data Abstract = Abstract | NotAbstract deriving Eq
 data Final = Final | NotFinal deriving Eq
-data Visibility = Public | Protected | Private | Internal
+data Visibility = Public | Protected | Private | Internal | ProtectedInternal
 data Static = Static | NotStatic deriving Eq
 data Async = Async | NotAsync deriving Eq
 data ModuleInternal = IsInternal | NotInternal deriving Eq
@@ -455,6 +455,7 @@ ppMethodModifiers container
       Protected -> "protected"
       Private -> "private"
       Internal -> "internal"
+      ProtectedInternal -> "protected internal"
     when (static==Static) $ tell ["static"]
     when (readonlyThis==IsReadOnly) $ tell ["readonly"]
     when (async==Async) $ tell ["async"]
@@ -472,6 +473,7 @@ ppPropertyModifiers container (PropertyMod abstract final visibility static) =
       Public -> "public"
       Protected -> "protected"
       Private -> "private"
+      ProtectedInternal -> "protected internal"
       Internal -> "internal"
     when (static==Static) $ tell ["static"]
 
@@ -680,6 +682,7 @@ fromHackVisibility v = case v of
   Hack.Visibility_Public -> Public
   Hack.Visibility_Protected -> Protected
   Hack.Visibility_Private -> Private
+  Hack.Visibility_ProtectedInternal -> ProtectedInternal
   Hack.Visibility_Internal -> Internal
   Hack.Visibility__UNKNOWN{} -> error "unexpected visibility"
 

glean/schema/source/hack.angle

@@ -105,7 +105,7 @@ predicate Signature :
   }
 
 # Visibility scope of declaration
-type Visibility = enum { Private | Protected | Public | Internal }
+type Visibility = enum { Private | Protected | Public | Internal | ProtectedInternal }
 
 # Variance (subtyping)
 type Variance = enum { Contravariant | Covariant | Invariant }