Glass connection warm-up

Summary:
The diff implement a connection warm-up mechanism in the GlassAccess constructor that sends the `getStatus` request to establish the connection. The diff also logs the timing.

Note: based on the tests with binary built with mode/opt flag file - the initialisation takes ~1.5sec. With mode/dev it will take up to 30sec

Reviewed By: Wilfred

Differential Revision: D78978796

fbshipit-source-id: 7f67feb963930a181e0cfaebb372d32364428692

Author: ivanmurashko

glean/client/swift/Clock.cpp

@@ -0,0 +1,21 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ * All rights reserved.
+ *
+ * This source code is licensed under the BSD-style license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#include "glean/client/swift/Clock.h"
+
+namespace facebook::glean::swift {
+
+Clock::Clock() : start_(std::chrono::high_resolution_clock::now()) {}
+
+int64_t Clock::duration() const {
+  auto now = std::chrono::high_resolution_clock::now();
+  return std::chrono::duration_cast<std::chrono::milliseconds>(now - start_)
+      .count();
+}
+
+} // namespace facebook::glean::swift

glean/client/swift/Clock.h

@@ -0,0 +1,27 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ * All rights reserved.
+ *
+ * This source code is licensed under the BSD-style license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#pragma once
+
+#include <chrono>
+
+namespace facebook::glean::swift {
+
+class Clock {
+ public:
+  Clock();
+  ~Clock() = default;
+
+  // Returns the duration in milliseconds since the Clock was created
+  int64_t duration() const;
+
+ private:
+  std::chrono::high_resolution_clock::time_point start_;
+};
+
+} // namespace facebook::glean::swift

glean/client/swift/GlassAccess.cpp

@@ -14,6 +14,7 @@
 #include <cstdlib>
 #include <memory>
 #include <stdexcept>
+#include "glean/client/swift/Clock.h"
 
 using namespace facebook;
 using apache::thrift::RpcOptions;
@@ -24,6 +25,7 @@ GlassAccess::GlassAccess() : client(nullptr), hgRoot_(getHgRoot()) {}
 
 std::optional<protocol::LocationList> GlassAccess::usrToDefinition(
     const std::string& usr) {
+  facebook::glean::swift::Clock clock;
   std::string msg;
 
   // Create USRToDefinitionRequest
@@ -42,6 +44,9 @@ std::optional<protocol::LocationList> GlassAccess::usrToDefinition(
         co_return co_await client->co_usrToDefinition(rpcOptions, request, ro);
       });
 
+  auto duration = clock.duration();
+  LOG(INFO) << "usrToDefinition request took " << duration << " milliseconds";
+
   if (!result.has_value()) {
     return std::nullopt;
   }
@@ -123,3 +128,32 @@ std::string GlassAccess::getHgRoot() {
 
   return result;
 }
+
+void GlassAccess::warmUpConnection() {
+  facebook::glean::swift::Clock clock;
+
+  LOG(INFO) << "Warming up Glass connection...";
+
+  try {
+    // Use getStatus to establish the connection
+    std::string msg;
+
+    // Call the Glass service getStatus
+    this->runGlassMethod<fb303::cpp2::fb_status>(
+        "getStatus", msg, [&]() -> folly::coro::Task<fb303::cpp2::fb_status> {
+          RpcOptions rpcOptions;
+          rpcOptions.setTimeout(std::chrono::milliseconds(GlassTimeoutMs));
+          co_return co_await client->co_getStatus(rpcOptions);
+        });
+
+    auto duration = clock.duration();
+
+    LOG(INFO) << "Glass connection established successfully in " << duration
+              << " milliseconds";
+  } catch (const std::exception& e) {
+    auto duration = clock.duration();
+
+    LOG(WARNING) << "Glass connection warm-up failed after " << duration
+                 << " milliseconds: " << e.what();
+  }
+}

glean/client/swift/GlassAccess.h

@@ -12,7 +12,6 @@
 #include <memory>
 #include "glean/client/swift/IGlassAccess.h"
 #include "glean/glass/if/gen-cpp2/GlassServiceAsyncClient.h"
-#include "glean/glass/if/gen-cpp2/glass_types.h"
 
 class GlassAccess : public IGlassAccess {
  public:
@@ -29,6 +28,7 @@ class GlassAccess : public IGlassAccess {
       std::string& msg,
       folly::Function<folly::coro::Task<T>()> f);
 
+  void warmUpConnection();
   std::unique_ptr<apache::thrift::Client<::glean::GlassService>> client;
 
  private:

glean/client/swift/GlassAccessLocal.cpp

@@ -16,4 +16,7 @@ GlassAccessLocal::GlassAccessLocal() {
   client = facebook::corp2prod::client::getClientFactory()
                .getClientUnique<apache::thrift::Client<::glean::GlassService>>(
                    connectionTier);
+
+  // Warm up the connection after client is initialized
+  warmUpConnection();
 }

glean/client/swift/GlassAccessRemote.cpp

@@ -20,4 +20,7 @@ GlassAccessRemote::GlassAccessRemote() {
       servicerouter::cpp2::getClientFactory()
           .getSRClientUnique<apache::thrift::Client<::glean::GlassService>>(
               connectionTier, params);
+
+  // Warm up the connection after client is initialized
+  warmUpConnection();
 }