You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary:
Ensure that all fact files merged using `glean merge` have a schema id; and that ID is the same across all input and output files.
## Part 1)
Support consistent Schema IDs when importing a facts JSON into an existing DB, which has the autoritativet schema to align with.
NOTE: This approach relies on JSON fact files implementing the `schema_id` metadata attribute, as implemented in T214992259. This limits which indexers' JSON fact files can be merged to those that implement `schema_id`. At the moment, C++ is OK, for example, but Python is not.
## Part 2)
Merge multiple JSON files into a single JSON file type merge using the inventory mechanism
# This diff implements...
This diff adds schema ID assertions to implement Part 1)
Reviewed By: pepeiborra
Differential Revision: D71329107
fbshipit-source-id: e7276e2546edf11a41ace05eb3f69738d95d9cc6
0 commit comments