Fix an assertion failure (#616)

Summary:
`Id::operator-=(a,b)` throws when a == b, because you're not supposed to make an invalid Id from a valid Id. So instead we use `uint64_t` to represent the page offsets, because those are not necesarily valid Ids.

This assertion triggered when I tried to add units to the Haskell indexer, I'm not sure why it hasn't triggered before.

Pull Request resolved: #616

Reviewed By: jjuliamolin

Differential Revision: D89959600

Pulled By: kbojarczuk

fbshipit-source-id: 3c93733e92f64dda0ad17f5ef297dd92a9823bd9

Author: simonmar

glean/rts/ownership.cpp

@@ -442,15 +442,18 @@ FOLLY_NOINLINE void completeOwnership(
   auto executor = folly::getGlobalCPUExecutor();
 
   folly::Future<folly::Unit> fetcher = folly::via(executor, [&]() {
-    auto pageOf = [](Id id) {
-      return Id::fromWord((id.toWord() / pageSize) * pageSize);
+    auto pageOf = [](Id id) -> uint64_t {
+      return (id.toWord() / pageSize) * pageSize;
     };
-    Id last = pageOf(lookup.firstFreeId() - 1);
-    Id first = pageOf(lookup.startingId());
-    for (Id id = last;; id -= pageSize) {
-      VLOG(1) << folly::sformat("fetching page: {}", id.toWord());
-      queue.blockingWrite(fetchPage(id, id + pageSize));
-      if (id == first) {
+    Id start = lookup.startingId();
+    Id last = lookup.firstFreeId() - 1;
+    uint64_t first = pageOf(start);
+    for (uint64_t page = pageOf(last);; page -= pageSize) {
+      VLOG(1) << folly::sformat("fetching page: {}", page);
+      queue.blockingWrite(fetchPage(
+          (page == first) ? start : Id::fromWord(page),
+          Id::fromWord(page + pageSize)));
+      if (page == first) {
         break;
       }
     }