[new-hs-indexer #17] Index instance declarations and class defaults - #551
[new-hs-indexer #17] Index instance declarations and class defaults#551simonmar wants to merge 1 commit into
Conversation
✅ Deploy Preview for fb-oss-glean ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
facebook-github-bot
added
the
CLA Signed
|
@phlalx has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
0c646c8 to
1490d88
Compare
|
@phlalx has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
7ad8145 to
ad423ba
Compare
|
|
||
| predicate InstanceDecl: | ||
| { | ||
| name: Name, |
There was a problem hiding this comment.
We can only remove defaultable fields from predicate. Was this on purpose?
There was a problem hiding this comment.
yes, it was deliberate. I'll need to rename it or bump the version again...
ad423ba to
817d5d9
Compare
We can now, for example, find all the places where a particular method is defined by an instance.
817d5d9 to
3d90706
Compare
|
@pepeiborra has imported this pull request. If you are a Meta employee, you can view this in D77440727. |
| class_: ClassDecl | | ||
| method: MethDecl | | ||
| instance: InstanceDecl | | ||
| instance: InstDecl | |
There was a problem hiding this comment.
This type change breaks Thrift compat.
Given that this is a rename, can it be safely ignored?
There was a problem hiding this comment.
You can always ignore Thrift compat issues, but I guess in this case it will also break schema validation... let me check
There was a problem hiding this comment.
It's weird, schema validation succeeds, but I think it should fail. Could be a bug.
There was a problem hiding this comment.
Ah no, I know why: it's because the change only affects derived predicates. It's always safe to change derived predicates because there's no data translation needed.
4 participants
We can now, for example, find all the places where a particular method
is defined by an instance.