Don't change working directory in the indexer - #558
Closed
simonmar wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for fb-oss-glean canceled.
|
facebook-github-bot
added
the
CLA Signed
simonmar
force-pushed
the
dont-cwd
branch
2 times, most recently
from
July 9, 2025 12:37
d77ae65 to
02eaa02
Compare
This reverts a change that was added as part of facebookincubator@77681e9 I'm sure there must have been a reason for it, but it breaks running tests in parallel. In general nothing should be changing the working directory, because it's process-wide.
Contributor
|
@pepeiborra has imported this pull request. If you are a Meta employee, you can view this in D78210500. |
pepeiborra
approved these changes
Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts a change that was added as part of
77681e9
I'm sure there must have been a reason for it, but it breaks running tests in parallel. In general nothing should be changing the working directory, because it's process-wide.