Skip to content

Fix m4 failure in glean.cabal.in - #567

Closed
simonmar wants to merge 1 commit into
facebookincubator:mainfrom
simonmar:fix-glean-cabal
Closed

Fix m4 failure in glean.cabal.in#567
simonmar wants to merge 1 commit into
facebookincubator:mainfrom
simonmar:fix-glean-cabal

Conversation

@simonmar

@simonmar simonmar commented Jul 17, 2025

Copy link
Copy Markdown
Collaborator

Didn't notice this because for some reason it doesn't cause a build failure, it just omitted a lot of the tests from glean.cabal.

$ make glean.cabal
rm -f glean.cabal
m4 -E -E -P .build/def/cxx/defs.m4 glean.cabal.in \
	| sed "/-- Copyright/a \\\n-- @""generated from glean.cabal.in\\n-- DO NO EDIT THIS FILE DIRECTLY" \
	> glean.cabal
m4:glean.cabal.in:2235: ERROR: end of file in string
chmod guo-w glean.cabal

Didn't notice this because for some reason it doesn't cause a build
failure, it just omitted a lot of the tests from glean.cabal.
@netlify

netlify Bot commented Jul 17, 2025

Copy link
Copy Markdown

Deploy Preview for fb-oss-glean canceled.

Name Link
🔨 Latest commit 8d1b2ee
🔍 Latest deploy log https://app.netlify.com/projects/fb-oss-glean/deploys/6878a7666fbec300085b6e26

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 17, 2025
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@pepeiborra has imported this pull request. If you are a Meta employee, you can view this in D78481866.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants